develooper Front page | perl.perl5.porters | Postings from August 2018

[perl #133476] [PATCH] Update PathTools with File::Path dep

Thread Next
From:
James E Keenan via RT
Date:
August 26, 2018 15:45
Subject:
[perl #133476] [PATCH] Update PathTools with File::Path dep
Message ID:
rt-4.0.24-6388-1535298312-1364.133476-15-0@perl.org
On Sun, 26 Aug 2018 02:04:14 GMT, etj@cpan.org wrote:
> This is a bug report for perl from etj@cpan.org,
> generated with the help of perlbug 1.40 running under perl 5.26.1.
> 
> From d873764f60160678d932bda37809c606f59bfdc7 Mon Sep 17 00:00:00 2001
> From: Ed J <etj@cpan.org>
> Date: Sat, 25 Aug 2018 21:53:02 +0100
> Subject: [PATCH] dep File::Path@2.02 for t/abs2rel.t
> 
> This is needed because Perl 5.8.8 has File::Path 1.08, which only supports
> mkpath([qw(dir1 dir2)], ...), not mkpath(qw(dir1 dir2), ...). That breaks
> PathTools/t/abs2rel.t on 5.8.8.
> ---
> dist/PathTools/Makefile.PL | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/dist/PathTools/Makefile.PL b/dist/PathTools/Makefile.PL
> index 11e04af523..cb0903688c 100644
> --- a/dist/PathTools/Makefile.PL
> +++ b/dist/PathTools/Makefile.PL
> @@ -36,6 +36,7 @@ WriteMakefile
>        'PREREQ_PM' => {
>                 'Carp' => '0',
>                 'File::Basename' => '0',
> +                'File::Path' => '2.02', # t/abs2rel.t uses 
> mkpath(@dirs,...)

If you're going to insert a dependency on File::Path, please require version 2.15.  Earlier versions have had significant security flaws.  2.15 is what we are distributing with perl-5.28.

Thank you very much.


>                 'Scalar::Util' => '0',
>                 # done_testing() is used in dist/Cwd/t/Spec.t
>                 'Test::More' => 0.88,

-- 
James E Keenan (jkeenan@cpan.org)

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=133476

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About