develooper Front page | perl.perl5.porters | Postings from July 2018

[perl #41202] text->float conversion gives wrong answer

Thread Next
From:
James E Keenan via RT
Date:
July 19, 2018 14:29
Subject:
[perl #41202] text->float conversion gives wrong answer
Message ID:
rt-4.0.24-7739-1532010548-522.41202-15-0@perl.org
On Thu, 19 Jul 2018 11:48:24 GMT, sisyphus@cpan.org wrote:
> 
> The version of numeric.c in the smoke-me/jkeenan/sisyphus/41202-text-
> float branch looks wrong to me. I don't think it includes the
> corrections that Karl made in commits
> d94e901a397f05e1d0030c5cfd535ef97a6808b6 and
> 6d37e916c310482d19ce4cd94848823cad43507a
> 
> Attached is the numeric.c patch against current blead (as at commit
> b2247a87...)
> 
> Could this please be applied to the smoke-me/jkeenan/sisyphus/41202-
> text-float branch.
> 
> Cheers,
> Rob

Replacement branch for smoke-testing:

smoke-me/jkeenan/sisyphus/41202-2nd-text-float

However, when I tried that locally, I encountered previously unseen failures in lib/locale.t:

#####
not ok 427 Verify that a different locale radix works when doing "==" with a constant
not ok 428 Verify that a different locale radix works when doing "==" with a scalar
...
not ok 432 Verify that "==" with a scalar and an intervening sprintf still works in inner no locale
...
...
not ok 435 Verify that after a no-locale block, a different locale radix still works when doing "==" with a scalar and an intervening sprintf
...
not ok 449 Verify atof with locale radix and negative exponent

Failed 5/682 subtests 

Test Summary Report
-------------------
../lib/locale.t (Wstat: 0 Tests: 682 Failed: 5)
  Failed tests:  427-428, 432, 435, 449
Files=1, Tests=682,  1 wallclock secs ( 0.06 usr  0.01 sys +  0.65 cusr  0.00 csys =  0.72 CPU)
Result: FAIL
#####

-- 
James E Keenan (jkeenan@cpan.org)

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=41202

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About