develooper Front page | perl.perl5.porters | Postings from July 2018

[perl #133197] [PATCH] win32/Makefile: prevent execution withoutCCTYPE set

From:
Steve Hay via RT
Date:
July 17, 2018 07:43
Subject:
[perl #133197] [PATCH] win32/Makefile: prevent execution withoutCCTYPE set
Message ID:
rt-4.0.24-27152-1531813419-1188.133197-15-0@perl.org
On Fri, 13 Jul 2018 14:17:49 -0700, bulk88 wrote:
> On Fri, 13 Jul 2018 00:38:52 -0700, shay wrote:
> > Thanks for the patch.
> >
> > The comment and the commit message both speak of deleting config.h,
> > but the patch actually deletes mini\.exists, and sure enough if I re-
> > run nmake with CCTYPE set afterwards then it just uses the (bad)
> > config.h that was written the first time rather than making a new
> > one.
> >
> > That's easily fixed and then I guess the change is good. It feels a
> > little clunky, but I can't think of a better way to do it right now.
> > The best solution, of course, would be to introduce some CCTYPE
> > version auto-detection like GNUmakefile and makefile.mk have into
> > this
> > Makefile, but this will do nicely until someone gets the tuits to do
> > that.
> 
> I think this patch is supposed to be applied after
> https://rt.perl.org/Ticket/Display.html?id=133196 where (mini)
> "config.h" is not a target anymore and was replaced by "mini/.exists"


Ah, yes. I was just looking at that one too! Both now applied to blead. This one is commit 404ca99ebbfbcec68dfe49176c26779a5da5bdf0, which I followed up with a slight clarification to the comment about config.h.

Thanks again for the patch.

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=133197



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About