develooper Front page | perl.perl5.porters | Postings from July 2018

Re: blead currently broken with -Dusequadmath builds

Thread Previous | Thread Next
From:
Karl Williamson
Date:
July 15, 2018 22:15
Subject:
Re: blead currently broken with -Dusequadmath builds
Message ID:
50bf0c65-9a29-365e-8b1a-7153043844fa@khwilliamson.com
On 07/14/2018 11:05 PM, sisyphus wrote:
> Hi,
> 
> Current blead (commit 76416d1), when built with -Dusequadmath, fails a 
> number of tests in re/uniprops_02.t and re/uniprops_03.t.
> 
> I believe the changes made to numeric.c since perl-5.28.0 was released 
> is (at least part of) the problem.
> 
> When I run those 2 failing test scripts post-build, I find that the 
> former fails 323 tests and the latter 118.
> 
> The errors are all of the form:
> 
> not ok 26457 - couldn't compile /\p{Nv=1.000000000000000e+06}/; line 
> 59989: Can't find Unicode property definition "Nv=1.000000000000000e+06" 
> in regex; marked by <-- HERE in m/\p{Nv=1.000000000000000e+06} <-- HERE 
> / at (eval 23170) line 2.
> 
> though the actual numeric values are not always "1.000000000000000e+06".
> 
> Cheers,
> Rob


This should be fixed by

commit d94e901a397f05e1d0030c5cfd535ef97a6808b6
  Author: Karl Williamson <khw@cpan.org>
  Date:   Sun Jul 15 12:27:20 2018 -0600

      Fix uninitialized error in my_atof3()

      This function, newly introduced in 5.29, by
      6928bedc792ff80f0cb915460a7eacae25fa9bdd, is buggy due to my 
misreading
      the man page for strtoflt128().  There was no man page on my 
system, and
      the one on-line is very terse, and could be interpreted as doing 
what I
      wanted, which is to have the second parameter on input point to 
the end
      position in the input string beyond which the function is not to look.
      But in fact the function is expecting a NUL-terminated string.

      This commit creates such a string by copying the original when it 
isn't
      NUL-terminated, before calling strtoflt128().

Attached is an updated version of Rob's patch.  It looks good to me, but 
I wonder if the Mingw stuff should be moved into perl.h?


Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About