develooper Front page | perl.perl5.porters | Postings from July 2018

[perl #133197] [PATCH] win32/Makefile: prevent execution withoutCCTYPE set

Thread Previous
From:
Steve Hay via RT
Date:
July 13, 2018 07:38
Subject:
[perl #133197] [PATCH] win32/Makefile: prevent execution withoutCCTYPE set
Message ID:
rt-4.0.24-13829-1531467532-781.133197-15-0@perl.org
Thanks for the patch.

The comment and the commit message both speak of deleting config.h, but the patch actually deletes mini\.exists, and sure enough if I re-run nmake with CCTYPE set afterwards then it just uses the (bad) config.h that was written the first time rather than making a new one.

That's easily fixed and then I guess the change is good. It feels a little clunky, but I can't think of a better way to do it right now. The best solution, of course, would be to introduce some CCTYPE version auto-detection like GNUmakefile and makefile.mk have into this Makefile, but this will do nicely until someone gets the tuits to do that.

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=133197

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About