develooper Front page | perl.perl5.porters | Postings from July 2018

[perl #133117] [PATCH] fix version autodetect for Visual C 64bitedition

From:
Steve Hay via RT
Date:
July 10, 2018 13:01
Subject:
[perl #133117] [PATCH] fix version autodetect for Visual C 64bitedition
Message ID:
rt-4.0.24-31521-1531227645-1026.133117-15-0@perl.org
On Wed, 25 Apr 2018 22:16:43 -0700, bulk88 wrote:
> On Wed, 25 Apr 2018 21:15:27 -0700, bulk88 wrote:
> > I've revised the patch description because of comments in
> > https://rt.perl.org/Ticket/Display.html?id=133126 and I added code to
> > deal with VC 2015 and VC 2017 but I can't test it on a real VC
> > 2015/2017. Test it please.
> 
> Patch revised again, I fixed the bug that "make info" without ANY
> compiler in PATH didn't print the error message in "info" target.

Please could you expand the following comment (in GNUmakefile) into more intelligible English?:

#rmving the cmd /c causes the var2b undef4echo but!4"set MSVCVER", cmd.exe bug?

(or just remove it? - it isn't in the equivalent section of code in makefile.mk).

Testing - I get slightly different output from the info target when using gmake vs dmake with gcc compilers - the dmake output is missing GCCTARGET (e.g. with mingw-w64.org 7.1.0 x86):

C:\Dev\Git\perl\win32>gmake info
# CCTYPE=GCC
# GCCBIN=gcc
# GCCVER=7.1.0
# GCCTARGET=i686-w64-mingw32
# GCCCROSS=
# WIN64=undef
# ARCHITECTURE=x86
# ARCHNAME=MSWin32-x86-multi-thread
# MAKE=gmake

C:\Dev\Git\perl\win32>dmake info
# CCTYPE=GCC
# CC=gcc
# GCCVER=7.1.0
# GCCTARGET=
# GCCCROSS=
# WIN64=undef
# ARCHITECTURE=x86
# ARCHNAME=MSWin32-x86-multi-thread
# MAKE=dmake

Otherwise this is looking good - tested with several gccs (mingw.org and mingw-w64.org), VC6 x86 and VC10/11/12/14/141 x86/x64.

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=133117



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About