develooper Front page | perl.perl5.porters | Postings from June 2018

Re: [perl #133236] Perl fails to build with libxcrypt

Thread Previous
From:
H.Merijn Brand
Date:
June 29, 2018 10:35
Subject:
Re: [perl #133236] Perl fails to build with libxcrypt
Message ID:
20180629123516.47b39b7b@pc09.procura.nl
On Thu, 31 May 2018 13:43:23 -0700, "Petr Pisar \(via RT\)"
<perlbug-followup@perl.org> wrote:

> # New Ticket Created by  Petr Pisar 
> # Please include the string:  [perl #133236]
> # in the subject line of all future correspondence about this issue. 
> # <URL: https://rt.perl.org/Ticket/Display.html?id=133236 >
> 
> 
> Hello,
> 
> Fedora Linux distribution decided
> <https://fedoraproject.org/wiki/Changes/Replace_glibc_libcrypt_with_libxcrypt>.
> to replace GNU libc's libcrypt with libxcrypt implementation
> <https://github.com/besser82/libxcrypt>. This caused perl to fail to build
> like this:
> 
> cc -c -DPERL_CORE -D_REENTRANT -D_GNU_SOURCE -I/usr/src/kernels/4.15.0-0.rc8.git0.1.fc28.x86_64/arch/x86/include -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -std=c89 -O2 -Wall -Werror=declaration-after-statement -Werror=pointer-arith -Wextra -Wc++-compat -Wwrite-strings pp.c
> pp.c: In function ‘Perl_pp_crypt’:
> pp.c:3654:47: error: ‘struct crypt_data’ has no member named ‘current_saltbits’
>       PL_reentrant_buffer->_crypt_struct_buffer->current_saltbits = 0;
>                                                ^~
> This is caused by a workaround for a broken glibc perl implements.
> 
> Attached patch fixes the failure by constraining the workaround only to broken
> glibc versions.
> 
> Original patch author is Björn Esser.
> 
> -- Petr

I vote +1 for this patch. Completely makes sense, esp for non-gcc
compilers (Solaris, HP-UX, AIX, ...)

-- 
H.Merijn Brand  http://tux.nl   Perl Monger  http://amsterdam.pm.org/
using perl5.00307 .. 5.27   porting perl5 on HP-UX, AIX, and openSUSE
http://mirrors.develooper.com/hpux/        http://www.test-smoke.org/
http://qa.perl.org   http://www.goldmark.org/jeff/stupid-disclaimers/

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About