develooper Front page | perl.perl5.porters | Postings from June 2018

Re: Can we ship 5.28.0 with cygwin broken?

Thread Previous
From:
Craig A. Berry
Date:
June 4, 2018 20:24
Subject:
Re: Can we ship 5.28.0 with cygwin broken?
Message ID:
CA+vYcVxNJ1pzGTSCQTYQ+BwqPgddf=5z784WA+Oi05r+OZDryg@mail.gmail.com
On Mon, Jun 4, 2018 at 2:09 PM, Achim Gratz <Stromeko@nexgo.de> wrote:
> Karl Williamson writes:
>> 2) https://rt.perl.org/Ticket/Display.html?id=133152 Cygwin build failure
>>
>> There is this patch:
>>
>> From: Tony Cook <tony@develop-help.com>
>> Date: Wed, 2 May 2018 11:15:30 +1000
>> Subject: [PATCH] (perl #133152) nostdio.h is broken, don't use it
>>
>> Is there a reason not to apply this patch, or to ship 5.28.0 now with
>> an expectation of a soon 5.28.1?  I think we used to expect the dot 1
>> to come out like a month after dot 0.
>
> I don't have any plans of moving Cygwin from 5.26 any time soon, so from
> the Cygwin perspective I'm OK with quickfixing (or even not fixing) this
> particular bug.

A safer quick fix might be to add Cygwin next to EBCDIC inside of
nostdio.h as a condition for skipping the redefines, though that would
not exclude the redefinition of FILE.

As far as I can tell, the purpose of nostdio.h is to prevent people
from using stdio calls in core without explicitly acknowledging that
they are mixing stdio and PerlIO by setting PERLIO_NOT_STDIO to zero.
Do we really not need that anymore?  Isn't it still possible we could
unwilttingly apply a patch that uses stdio calls and seems to work ok
but causes less immediately obvious problems by bypassing the layers?

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About