On 22 May 2018 at 17:52, Steve Hay <steve.m.hay@googlemail.com> wrote: > On 22 May 2018 at 09:55, Dave Mitchell <davem@iabyn.com> wrote: >> On Mon, May 14, 2018 at 06:03:02PM +0100, Steve Hay via perl5-porters wrote: >>> On 10 May 2018 at 14:01, Steve Hay <steve.m.hay@googlemail.com> wrote: >>> > On 10 May 2018 at 10:29, Dave Mitchell <davem@iabyn.com> wrote: >>> >> On Sat, Apr 28, 2018 at 03:12:58PM +0100, Steve Hay via perl5-porters wrote: >>> >>> Now in blead in commit 4bd4e9335ffc257cbe2bf1a42789f693f5797337. >>> >>> >>> >>> (Actually, I'm still confused why Socket failed given that Windows >>> >>> doesn't compile cpan/ differently to dist/ and ext/, but I've spent >>> >>> too long staring at this now...) >>> >>> >>> >>> That just leaves the GCC fixes from bulk88 to deal with on this >>> >>> ticket. I'll look at them soon if nobody else gets there first. >>> >> >>> >> Are tou likely to be able to look at these? >>> >> >>> > >>> > Yes, I will do. Sorry for the delay. Not even being able to build in >>> > normal C mode with recent mingw.org compilers (RT#128631) hasn't >>> > helped, but I will go back to mingw-w64 compilers for these fixes. >>> >>> Finally tried this out, using MinGW-w64 compilers (6.3.0 and 7.1.0). I >>> tried x86 versions with and without USE_CPLUSPLUS and all is well. (I >>> thought MinGW 4.8.1 would work as well, but it has trouble with fstat >>> calls and is only happy in normal C mode - see perl #128631. I'm not >>> going to worry about that...) >> >> Should this work so far be applied in time for an -RC2? >> > > Yes, I think so. It's not complete, but it's an improvement on the > current situation. If the remaining problems don't get fixed in time > then I guess the failures will just have to be documented, as I'm > already (still) intending to do for the failing mingw.org compilers > (see #128631). > > I don't think the C++ build trouble is a showstopper anyway. Most > people probably don't use it other than as a means to check the build > with different compiler options (it generally throws up more warnings > and/or turns previously overlooked warnings into errors). I've now pushed the main patch here in commit a385474c9667eb0a1b5fbba5f817d90686929349. The remaining problems (along with those reported on #128631) are also now documented (in commit 8a217c9aa73da6153273a3bfa4c89fa15e95587b), but I think we can probably remove this ticket from the blockers list now. I will do that in the next couple of days unless anyone objects.Thread Previous | Thread Next