develooper Front page | perl.perl5.porters | Postings from April 2018

[perl #133153] [PATCH] Time-HiRes: Fix generating Makefile when itdoes not exist

Thread Previous
From:
perlbug-followup
Date:
April 25, 2018 11:30
Subject:
[perl #133153] [PATCH] Time-HiRes: Fix generating Makefile when itdoes not exist
Message ID:
rt-4.0.24-27540-1524655836-1850.133153-75-0@perl.org
# New Ticket Created by   
# Please include the string:  [perl #133153]
# in the subject line of all future correspondence about this issue. 
# <URL: https://rt.perl.org/Ticket/Display.html?id=133153 >


More times when compiling/updating perl codebase I'm getting following
compile error:

./miniperl -Ilib make_ext.pl lib/auto/Time/HiRes/HiRes.so  MAKE="make" LIBPERL_A=libperl.a LINKTYPE=dynamic
Makefile.PL: The "xdefine" exists, skipping the configure step.
Use "/home/pali/perl/miniperl Makefile.PL --configure"
or: "/home/pali/perl/miniperl Makefile.PL --force
to force the configure step.
Warning: No Makefile!
make[1]: Entering directory '/home/pali/perl/dist/Time-HiRes'
make[1]: *** No rule to make target 'all'.  Stop.
make[1]: Leaving directory '/home/pali/perl/dist/Time-HiRes'
make[1]: Entering directory '/home/pali/perl/dist/Time-HiRes'
make[1]: *** No rule to make target 'all'.  Stop.
make[1]: Leaving directory '/home/pali/perl/dist/Time-HiRes'
Unsuccessful make(dist/Time-HiRes): code=512 at make_ext.pl line 570.
makefile:582: recipe for target 'lib/auto/Time/HiRes/HiRes.so' failed
make: *** [lib/auto/Time/HiRes/HiRes.so] Error 2

Reason is that Makfile.PL does not generate Makefile if --configure or
--force is not specified. And it does not generate it even when Makefile
does not exist.

It is really ridiculous that Makefile.PL does not generate Makefile without
specifying some non-standard flags which even make_ext.pl does not support.

This patch ensures that Makefile is always generated when Makefile.PL is
called despite which arguments were passed. So it fixes above problem with
compilation.

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About