Front page | perl.perl5.porters |
Postings from April 2018
Commit 71e845c: why?
Thread Next
From:
James E Keenan
Date:
April 24, 2018 12:58
Subject:
Commit 71e845c: why?
Message ID:
20180424125828.3455.qmail@lists-nntp.develooper.com
What is the rationale for this commit at this point in our development
cycle?
#####
commit 71e845c3420f2496b845cf717d584dcaa063f4bf
Author: Yves Orton <demerphq@gmail.com>
AuthorDate: Tue Apr 24 12:45:29 2018 +0200
Commit: Yves Orton <demerphq@gmail.com>
CommitDate: Tue Apr 24 12:45:34 2018 +0200
fixup for NO_TAINT_SUPPORT
diff --git a/regexp.h b/regexp.h
index c7112d3..44409f0 100644
--- a/regexp.h
+++ b/regexp.h
@@ -474,6 +474,7 @@ and check for NULL.
# define RX_MATCH_TAINTED(rx_sv) 0
# define RXp_MATCH_TAINTED_on(prog) NOOP
# define RX_MATCH_TAINTED_on(rx_sv) NOOP
+# define RXp_MATCH_TAINTED_off(prog) NOOP
# define RX_MATCH_TAINTED_off(rx_sv) NOOP
#else
# define RX_ISTAINTED(rx_sv) (RX_EXTFLAGS(rx_sv) & RXf_TAINTED)
#####
It contains no test. It doesn't reference any bug ticket. We're in
code freeze, so it shouldn't have been committed absent the pumpking's
authorization.
It should be reverted and saved for discussion in 5.29.0.
Thank you very much.
Jim Keenan
Thread Next
-
Commit 71e845c: why?
by James E Keenan