Front page | perl.perl5.porters |
Postings from April 2018
On 04/22/2018 08:55 AM, Sawyer X wrote: > > > On 04/22/2018 02:45 PM, James E Keenan wrote: >> On 04/22/2018 05:19 AM, Dan Kogai wrote: >>> Porters, >>> >>> Just VERSION++’ed Encode. Functionally it is identical to the >>> previous version. Just XS cleanups to reflect Perl API changes. >> >> >> Because we're now in pre-5.28.0 code freeze, I believe this should *not* >> be merged into core until 5.29.0 -- unless the pumpking decides >> otherwise. > > Jim is correct. This should not be merged. It can be in a branch to be > merged next month. > In any event, it's not ready for merge. There's one version number that wasn't updated. ##### $ cd t;./perl harness -v porting/cmp_version.t; cd - ok 1 - cpan/Encode/Encode.pm not ok 2 - cpan/Encode/Unicode/Unicode.pm version 2.17 # not ok 2 - cpan/Encode/Unicode/Unicode.pm version 2.17 ok 3 - dist/Storable/__Storable__.pm ok 4 - lib/B/Op_private.pm Failed 1/4 subtests Test Summary Report ------------------- porting/cmp_version.t (Wstat: 0 Tests: 4 Failed: 1) Failed test: 2 Files=1, Tests=4, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.09 cusr 0.01 csys = 0.11 CPU) Result: FAIL /home/jkeenan/gitwork/perl #####Thread Previous | Thread Next