Front page | perl.perl5.porters |
Postings from April 2018
[perl #132955] USE_CPLUSPLUS build broken in 5.27 blead and all 5.26stables
Thread Previous
|
Thread Next
From:
bulk88 via RT
Date:
April 20, 2018 06:09
Subject:
[perl #132955] USE_CPLUSPLUS build broken in 5.27 blead and all 5.26stables
Message ID:
rt-4.0.24-17131-1524204536-1895.132955-15-0@perl.org
On Thu, 19 Apr 2018 09:17:31 -0700, xsawyerx@cpan.org wrote:
> On Sun, 15 Apr 2018 18:24:06 -0700, jkeenan wrote:
> > On Sat, 14 Apr 2018 16:39:11 GMT, public@khwilliamson.com wrote:
> > > On 04/13/2018 04:34 PM, Leon Timmermans wrote:
> > > > On Fri, Apr 13, 2018 at 9:13 PM, James E Keenan <jkeenan@pobox.com>
> > > > wrote:
> > > >> On 04/13/2018 11:36 AM, Leon Timmermans wrote:
> > > >>> literal operators are a C++11-ism. Adding spaces between a
> > > >>> literal
> > > >>> string and a term like HEKf or NVff should solve that.
> > > >>>
> > > >>> Leon
> > > >>>
> > > >>
> > > >> This may relate to part of the synching I performed yesterday.
> > > >> Consider
> > > >> this part of commit d3a5b29c73b5a2fd6524ca:
> > > >>
> > > >> #####
> > > >> diff --git a/vxs.inc b/vxs.inc
> > > >> index 0e5e72a..b5c00d7 100644
> > > >> --- a/vxs.inc
> > > >> +++ b/vxs.inc
> > > >> @@ -138,7 +138,7 @@ VXS(universal_version)
> > > >> name, SvPVx_nolen_const(req));
> > > >> #else
> > > >> Perl_croak(aTHX_
> > > >> - "%" HEKf " does not define $%"HEKf
> > > >> + "%" HEKf " does not define $%" HEKf
> > > >> "::VERSION--version check failed",
> > > >> HEKfARG(name), HEKfARG(name));
> > > >> #endif
> > > >> #####
> > > >>
> > > >> This was a case where, prior to this commit, there was a
> > > >> difference
> > > >> between
> > > >> the previous CPAN version and what was in blead. Probably this
> > > >> was
> > > >> why
> > > >> 'vxs.inc' was in the CUSTOMIZED list in the 'version' data in
> > > >> %Modules in
> > > >> Porting/Maintainers.pl. Amid all the other problems I had
> > > >> performing that
> > > >> sync, I decided in this case to go with the maintainer rather than
> > > >> blead.
> > > >> That may well have been the wrong call.
> > > >>
> > > >> If that is so, then what should probably happen is: (a) revert the
> > > >> diff
> > > >> above; (b) test as per the complaint in this ticket; and (c) send
> > > >> what
> > > >> previously was in blead and is once again in blead upstream as a
> > > >> patch.
> > > >
> > > > I believe the attached patch will fix that issue, but I haven't
> > > > tested
> > > > it properly.
> > > >
> > > > Leon
> > > >
> > >
> > > Yes, the issue is a result of the cpan overwrite of what is in blead.
> > > Leon's patch isn't necessary, as I had already sent an equivalent
> > > patch
> > > to the maintainer, and that got applied and pushed into what Jim
> > > merged.
> > >
> > > The problem, which I alluded to in my post, is that vutil.c lost some
> > > necessary white space. That white space was included in a previous
> > > version of vutil.c, and I suspect the reason it got lost is that
> > > there
> > > are currently two repositories of 'version', and it was only in one.
> > > I
> > > have emailed a patch to the maintainer.
> >
> > (09:22:14 PM) ***p5commits James Keenan pushed to blead (v5.27.10-136-
> > ga684213360): John Peacock: Synch cpan/version/* and other files with
> > CPAN version 0.9923.;
> > https://perl5.git.perl.org/perl.git/commitdiff/a6842133
>
> So should this be resolved?
I still can't build C++ perl because of PL_nan wrong declaration by jhi https://perl5.git.perl.org/perl.git/commitdiff/0879cd66ef3f00918ae26d9bb7ac555d3911c548 . The lvalue cast and C++11 postfix operator space issues were found by others, not me.
--
bulk88 ~ bulk88 at hotmail.com
---
via perlbug: queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=132955
Thread Previous
|
Thread Next