develooper Front page | perl.perl5.porters | Postings from April 2018

Re: [perl #132955] USE_CPLUSPLUS build broken in 5.27 blead andall5.26 stables

Thread Previous
Karl Williamson
April 14, 2018 16:39
Re: [perl #132955] USE_CPLUSPLUS build broken in 5.27 blead andall5.26 stables
Message ID:
On 04/13/2018 04:34 PM, Leon Timmermans wrote:
> On Fri, Apr 13, 2018 at 9:13 PM, James E Keenan <> wrote:
>> On 04/13/2018 11:36 AM, Leon Timmermans wrote:
>>> literal operators are a C++11-ism. Adding spaces between a literal
>>> string and a term like HEKf or NVff should solve that.
>>> Leon
>> This may relate to part of the synching I performed yesterday.  Consider
>> this part of commit d3a5b29c73b5a2fd6524ca:
>> #####
>> diff --git a/ b/
>> index 0e5e72a..b5c00d7 100644
>> --- a/
>> +++ b/
>> @@ -138,7 +138,7 @@ VXS(universal_version)
>>                              name, SvPVx_nolen_const(req));
>>   #else
>>                  Perl_croak(aTHX_
>> -                          "%" HEKf " does not define $%"HEKf
>> +                          "%" HEKf " does not define $%" HEKf
>>                             "::VERSION--version check failed",
>>                             HEKfARG(name), HEKfARG(name));
>>   #endif
>> #####
>> This was a case where, prior to this commit, there was a difference between
>> the previous CPAN version and what was in blead.  Probably this was why
>> '' was in the CUSTOMIZED list in the 'version' data in %Modules in
>> Porting/  Amid all the other problems I had performing that
>> sync, I decided in this case to go with the maintainer rather than blead.
>> That may well have been the wrong call.
>> If that is so, then what should probably happen is: (a) revert the diff
>> above; (b) test as per the complaint in this ticket; and (c) send what
>> previously was in blead and is once again in blead upstream as a patch.
> I believe the attached patch will fix that issue, but I haven't tested
> it properly.
> Leon

Yes, the issue is a result of the cpan overwrite of what is in blead. 
Leon's patch isn't necessary, as I had already sent an equivalent patch 
to the maintainer, and that got applied and pushed into what Jim merged.

The problem, which I alluded to in my post, is that vutil.c lost some 
necessary white space.  That white space was included in a previous 
version of vutil.c, and I suspect the reason it got lost is that there 
are currently two repositories of 'version', and it was only in one.  I 
have emailed a patch to the maintainer.

Thread Previous Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About