Front page | perl.perl5.porters |
Postings from April 2018
On 04/13/2018 11:36 AM, Leon Timmermans wrote:
> On Fri, Apr 13, 2018 at 5:24 PM, Steve Hay via perl5-porters
> <perl5-porters@perl.org> wrote:
>> On 13 April 2018 at 16:21, Karl Williamson <public@khwilliamson.com> wrote:
>>> On 04/13/2018 09:05 AM, Karl Williamson wrote:
>>>>
>>>> On 04/13/2018 08:57 AM, Karl Williamson wrote:
>>>>>
>>>>> What was the latest commit in blead that this was this run on? The first
>>>>> line of the output from
>>>>> ./perl -v
>>>>> would give me the answer
>>>>
>>>>
>>>> Actually, to save email back-and-forths, if you ran it on the very latest
>>>> version of blead, as of this moment, with
>>>> d3a5b29c73b5a2fd6524ca1f8c5c779bd8cb0687
>>>> which copied cpan's 'version' onto bleads, that took a step backwards in
>>>> vutil.c, introducing issues of just the sort that your output shows.
>>>>
>>>
>>> And so, if you run it on blead just prior to that commit, we could see if
>>> there are other issues in vutil.c that I don't know about. The maintainer
>>> of version, after a hiatus, is currently very involved in fixing it, and so
>>> would likely act swiftly to fix anything found.
>>
>> The result I reported was on d3a5b29c73b5a2fd6524ca1f8c5c779bd8cb0687,
>> which I'd updated to in the hope that it might fix the build since I'd
>> previously tried with the previous commit
>> (1b30b4a8259a74c5ffaee362bc1d881c40fc5279), which had failed like
>> this:
>>
>> cl -c -nologo -GF -W3 -TP -EHsc -I..\lib\CORE -I.\include -I. -I..
>> -DWIN32 -D_CONSOLE -DNO_STRICT -D_CRT_SECURE_NO_DEPRECATE
>> -D_CRT_NONSTDC_NO_DEPRECATE -D_WINSOCK_DEPRECATED_NO_WARNINGS
>> -DPERLDLL -DPERL_CORE -O1 -MD -Zi -DNDEBUG -GL -DPERL_EXTERNAL_GLOB
>> -DPERL_IS_MINIPERL -Fo.\mini\universal.obj ..\universal.c
>> universal.c
>> c:\dev\git\perl\vxs.inc(142): error C3688: invalid literal suffix
>> 'HEKf'; literal operator or literal operator template 'operator
>> ""HEKf' not found
>> NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 14.0
>> \VC\BIN\cl.EXE"' : return code '0x2'
>> Stop.
>
> literal operators are a C++11-ism. Adding spaces between a literal
> string and a term like HEKf or NVff should solve that.
>
> Leon
>
This may relate to part of the synching I performed yesterday. Consider
this part of commit d3a5b29c73b5a2fd6524ca:
#####
diff --git a/vxs.inc b/vxs.inc
index 0e5e72a..b5c00d7 100644
--- a/vxs.inc
+++ b/vxs.inc
@@ -138,7 +138,7 @@ VXS(universal_version)
name, SvPVx_nolen_const(req));
#else
Perl_croak(aTHX_
- "%" HEKf " does not define $%"HEKf
+ "%" HEKf " does not define $%" HEKf
"::VERSION--version check failed",
HEKfARG(name), HEKfARG(name));
#endif
#####
This was a case where, prior to this commit, there was a difference
between the previous CPAN version and what was in blead. Probably this
was why 'vxs.inc' was in the CUSTOMIZED list in the 'version' data in
%Modules in Porting/Maintainers.pl. Amid all the other problems I had
performing that sync, I decided in this case to go with the maintainer
rather than blead. That may well have been the wrong call.
If that is so, then what should probably happen is: (a) revert the diff
above; (b) test as per the complaint in this ticket; and (c) send what
previously was in blead and is once again in blead upstream as a patch.
Let me know if you need further assistance.
Thank you very much.
Jim Keenan
Thread Previous
|
Thread Next