On 03/08/2018 11:31 PM, Matthew Horsfall (alh) wrote: > On Thu, Mar 1, 2018 at 9:05 PM, Matthew Horsfall (alh) > <wolfsage@gmail.com> wrote: >> On Wed, Feb 28, 2018 at 1:13 PM, Father Chrysostomos <sprout@cpan.org> wrote: >>> Maybe we should change the rmg to require that the release commit be >>> pushed and tagged before the actual release is made. This will pre- >>> vent a recurrence. >> This makes sense to me! >> > Sawyer, any thoughts here? (or anyone else?) I think both options are equally problematic. If you release the tarball and then can't push or if you push but then realize you need to regen the tarball. The pushing of tag and commits is a commitment to the tarball you created and there's no way back. We're only asking what we think is more likely: A permission problem or a need to regen the tarball after you created the tag. (The latter happened to me once, IIRC.) The one possible benefit of changing it is that it lowers the time-frame in which others push commits, but the only case I can think of in which it matters is perldelta. By freeze most changes (definitely any that would require a change in perldelta) should be in a branch anyway, no?Thread Previous | Thread Next