develooper Front page | perl.perl5.porters | Postings from March 2018

[perl #132925] [PATCH] regen_lib.pl dont output Windows path seps onWindows

From:
Tony Cook via RT
Date:
March 6, 2018 04:12
Subject:
[perl #132925] [PATCH] regen_lib.pl dont output Windows path seps onWindows
Message ID:
rt-4.0.24-20082-1520309550-268.132925-15-0@perl.org
On Thu, 01 Mar 2018 13:23:07 -0800, bulk88 wrote:
> On Wed, 28 Feb 2018 20:48:30 -0800, tonyc wrote:
> > On Wed, 28 Feb 2018 18:20:29 -0800, bulk88 wrote:
> > > See attached patch. Diff of what goes wrong when
> > > charclass_invlists.h
> > > regened on windows.
> >
> > Your patch is a workaround for bugs in mktables and in
> > mk_invlists.pl.
> >
> > a) mktables attempts to write out canonical pathnames, but due to a
> > lexcial scoping issue, doesn't.
> >
> > b) mk_invlists.pl uses $0 for itself as a dependency rather than the
> > literal that the other regen scripts that I looked at.
> >
> > You'll only encounter b) if you run mk_invlists.pl manually -
> > regen.pl
> > will run it as "regen/mk_invlists.pl" which matches the POSIX-ish
> > name.
> 
> As far as I can tell regen.pl never runs mk_invlists.pl, either it is
> manually run, or it its in TAP mode by from porting/regen.t,

You're right, I think I got mixed up with porting/regen.t, which runs it with the /.

> Your 2 patches fix the pathnames being rewriten if I regen the files,
> so feel free to push those 2 patches and reject my attempt at a fix.

Thanks for the feedback.

Applied as b857191d01c23df63dc1112e443b194a13305179 and b857191d01c23df63dc1112e443b194a13305179.

Tony

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=132925



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About