develooper Front page | perl.perl5.porters | Postings from March 2018

[perl #132925] [PATCH] regen_lib.pl dont output Windows path seps onWindows

Thread Next
From:
bulk88 via RT
Date:
March 1, 2018 21:23
Subject:
[perl #132925] [PATCH] regen_lib.pl dont output Windows path seps onWindows
Message ID:
rt-4.0.24-6663-1519939387-1055.132925-15-0@perl.org
On Wed, 28 Feb 2018 20:48:30 -0800, tonyc wrote:
> On Wed, 28 Feb 2018 18:20:29 -0800, bulk88 wrote:
> > See attached patch. Diff of what goes wrong when charclass_invlists.h
> > regened on windows.
> 
> Your patch is a workaround for bugs in mktables and in mk_invlists.pl.
> 
> a) mktables attempts to write out canonical pathnames, but due to a
> lexcial scoping issue, doesn't.
> 
> b) mk_invlists.pl uses $0 for itself as a dependency rather than the
> literal that the other regen scripts that I looked at.
> 
> You'll only encounter b) if you run mk_invlists.pl manually - regen.pl
> will run it as "regen/mk_invlists.pl" which matches the POSIX-ish
> name.

As far as I can tell regen.pl never runs mk_invlists.pl, either it is manually run, or it its in TAP mode by from porting/regen.t,

Your 2 patches fix the pathnames being rewriten if I regen the files, so feel free to push those 2 patches and reject my attempt at a fix.

-- 
bulk88 ~ bulk88 at hotmail.com

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=132925

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About