develooper Front page | perl.perl5.porters | Postings from March 2018

Re: [perl #132902] Blead Breaks CPAN: Class::Std

Thread Previous | Thread Next
From:
demerphq
Date:
March 1, 2018 08:51
Subject:
Re: [perl #132902] Blead Breaks CPAN: Class::Std
Message ID:
CANgJU+W0qd23A2wGdg=ysQO4LwUOexZTUPy+ihz=C-4-Pjm=EA@mail.gmail.com
On 1 March 2018 at 09:47, bulk88 via RT <perlbug-followup@perl.org> wrote:
> On Thu, 01 Mar 2018 00:22:19 -0800, demerphq wrote:
>> On 28 February 2018 at 16:03, demerphq <demerphq@gmail.com> wrote:
>> > On 28 February 2018 at 06:41, Father Chrysostomos via RT
>> > <perlbug-followup@perl.org> wrote:
>> >> On Tue, 27 Feb 2018 20:21:24 -0800, bulk88 wrote:
>> >>> On Tue, 27 Feb 2018 20:04:14 -0800, bulk88 wrote:
>> >>> > Commit 5c8d fails badly on Windows for me.
>> >>>
>> >>> There are no quotes in the cmd line to the process
>> >>> ------------------------
>> >>> Command line:   C:\p525\src\t\perl.exe -e
>> >>>          use Carp;
>> >>>          sub foom {
>> >>>              Carp::confess("Looks lark we got a error: $_[0]")
>> >>>          }
>> >>>          BEGIN {
>> >>>              *{"o::()"} = sub {};
>> >>>              *{'o::(""'} = sub {"hay"};
>> >>>              $o::OVERLOAD{dummy}++; # perls before 5.18 need this
>> >>>              *{"CODE::()"} = sub {};
>> >>>              $SIG{__DIE__} = sub { foom (@_, bless([], o), sub {})
>> >>> }
>> >>>          }
>> >>>        $a +
>> >>>
>> >>> ------------------------------------
>> >>>
>> >>> but Carp.t which has identical code (or almost?) does put "s in the
>> >>> command line foe -e's arg.
>> >>
>> >> I suspect IPC::Open3 (or something it calls) is adding the quotation
>> >> marks if the argument has none.
>> >>
>> >> Would it be feasible to feed the program to stdin and drop -e?
>> >
>> > I just pushed:
>> >
>> > commit 01d4cc0fe2b9e198c9146d4c84e781b5d2d3117f
>> > Author: Yves Orton <demerphq@gmail.com>
>> > Date:   Wed Feb 28 16:02:17 2018 +0100
>> >
>> > rework Carp/t/stack_after_err.t to not use perl -e
>>
>> Bulk88 can you confirm this patch fixed the win32 build issue?
>>
>> Yves
>
> works for me
> -------------------------------------------
> C:\perl521\src\win32>cd ..\t   & perl harness -v ../dist/Carp/t/stack_after_err.
> t   & cd ..\win32
> ../dist/Carp/t/stack_after_err.t ..
> 1..4
> ok 1 - Carp does not try to load modules on demand for overloaded args
> ok 2 - StrVal fallback in the presence of UNIVERSAL::isa
> ok 3 - StrVal fallback in the presence of UNIVERSAL::can
> ok 4 - StrVal fallback in the presence of UNIVERSAL::can/isa
> ok
> All tests successful.
> Files=1, Tests=4,  0 wallclock secs ( 0.00 usr +  0.00 sys =  0.00 CPU)
> Result: PASS

Great. Thanks for the report!

cheers,
Yves

-- 
perl -Mre=debug -e "/just|another|perl|hacker/"

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About