develooper Front page | perl.perl5.porters | Postings from February 2018

Re: Storable auto-config logic is a nuisance

Thread Previous | Thread Next
From:
demerphq
Date:
February 25, 2018 16:16
Subject:
Re: Storable auto-config logic is a nuisance
Message ID:
CANgJU+UCRJKZBcsE9myQbomudOvd9fLJfY0M9xezR_1UjsABEg@mail.gmail.com
On 25 February 2018 at 13:58, demerphq <demerphq@gmail.com> wrote:
> Sometime recently storable started doing a build time probe to
> determine stack recursion limits.
>
> This is annoying when building Perl over and over.
>
> I also wonder if it makes that much sense, I would have expected that
> most Perls are built in a different environment than they are run in,
> at least in Linux. Thus any computations made in the build environment
> have little relevance to those from the
> run-time environment.
>
> Regardless, it seems wrong that we run this stacksize detection logic
> every time we run 'make'.
>
> Can we change this so it reuses whatever computations it has made in a
> previous run?

To implement this I have applied the following:

commit 345db0f66ed0ac7b609bb6bcceaf3a48b5f8e25b
Author: Yves Orton <demerphq@gmail.com>
Date:   Sun Feb 25 15:03:57 2018 +0100

    Storable: when building in core do not run stacksize every time

diff --git a/dist/Storable/__Storable__.pm b/dist/Storable/__Storable__.pm
index 52ce162..f7acfeb 100644
--- a/dist/Storable/__Storable__.pm
+++ b/dist/Storable/__Storable__.pm
@@ -27,7 +27,7 @@ our @EXPORT_OK = qw(

 our ($canonical, $forgive_me);

-our $VERSION = '3.06';
+our $VERSION = '3.07';

 our $recursion_limit;
 our $recursion_limit_hash;
diff --git a/dist/Storable/stacksize b/dist/Storable/stacksize
index 394e6aa..27aa6f3 100644
--- a/dist/Storable/stacksize
+++ b/dist/Storable/stacksize
@@ -45,6 +45,7 @@ elsif (system("ulimit -c 0 ;") == 0) {
 }
 if (@ARGV and $ARGV[0] eq '--core') {
     $ENV{PERL_CORE} = 1;
+    exit if -e "dist/Storable/$fn";
 }
 my $PERL = $^X;
 if ($ENV{PERL_CORE}) {



-- 
perl -Mre=debug -e "/just|another|perl|hacker/"

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About