develooper Front page | perl.perl5.porters | Postings from February 2018

Re: [perl #132892] Possibly memory leak when matching strings usingpre-compiled regexes stored in hash key (perl >= v5.26)

Thread Previous | Thread Next
From:
demerphq
Date:
February 25, 2018 15:27
Subject:
Re: [perl #132892] Possibly memory leak when matching strings usingpre-compiled regexes stored in hash key (perl >= v5.26)
Message ID:
CANgJU+VuxTh5VtLd48HBOTbHmOaj+4LxOgdQA+NHJHHqXrsTwA@mail.gmail.com
On 25 February 2018 at 16:21, Sawyer X <xsawyerx@gmail.com> wrote:
> On 02/25/2018 12:13 PM, demerphq wrote:
>> On 25 February 2018 at 11:00, Sergey Aleynikov via RT
>> <perlbug-followup@perl.org> wrote:
>>> On Fri, 23 Feb 2018 01:35:02 -0800, demerphq wrote:
>>>> Fixed in 910a6a8be166fb3780dcd2520e3526e537383ef2
>>> Since this is a regression in 5.26, should it also be added to voting list for the future 5.26.2? Or there're no plans for it?
>
> It should be, yes!
>
>> Sure. I don't remember how to do that tho.  Where does the voting list
>> live again?
>
> The branch "maint-votes" in git. I've added them here:
>
> https://perl5.git.perl.org/perl.git/commitdiff/5f21d69b722f6a73f185e533ecf138e17adeabce
>
> With a vote from both of us, Yves.

Thanks, I was busy trying to test Sergey Aleynikov's suggestion of
using SvIsCOW_shared_hash when my perl build started throwing some
weird ass errors, so assuming that the reboot and clean build i just
did makes the weirdness go away, there might be one more commit
required. For something like this is it preferred to backport the full
patch sequence, or is it preferable to prepare a squashed version?

Yves

-- 
perl -Mre=debug -e "/just|another|perl|hacker/"

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About