develooper Front page | perl.perl5.porters | Postings from February 2018

Re: [perl #131046] [PATCH] Carp: Do not crash when reading @DB::args

Thread Previous | Thread Next
February 24, 2018 16:07
Re: [perl #131046] [PATCH] Carp: Do not crash when reading @DB::args
Message ID:
On 24 February 2018 at 16:39, Father Chrysostomos via RT
<> wrote:
> On Sat, 24 Feb 2018 04:33:59 -0800, demerphq wrote:
>> On 24 February 2018 at 01:00, Zefram <> wrote:
>> > Bonus problem: the patch desynchronises the version numbers of Carp
>> > and
>> > Carp::Heavy, giving the former an unjustified underscored version.
>> /This/ point we need to debate. :-)
>> I believe that every distinct code state of a module in dist/ should
>> have a distinct version number.
> Every commit?  Or just every release?

Every commit. And I thought we had tests for that too. Maybe I am
wrong tho. I haven't double checked. Anytime i have run a full
make-test after modifying something in dist i have also bumped the
version number.

>> I also believe that minor changes in dist modules during the lifetime
>> of a dev version should be marked as a "dev" versions, and that only
>> prior to release should we bump them to a "non-dev" version. I believe
>> that others have felt the same way in at least some cases as Carp has
>> code to defend against dev/underbar versions.
> That puts a burden on perl maintainers to remember which version scheme to use in each case.  I seem to remember it was Ricardo Signes that ruled that upstream-blead modules should not have underscores in their versions.  That makes things much simpler for me, at least.

Er, I would have thought that it would be simple. Use underbars, and
only when preparing a release should we change to a non-underbar.

Anyway, since you say Ricardo ruled otherwise, then I accept that.
Perhaps we should remove the support for underbars from the code.

>> Related to this, I have bumped the versions twice now, meaning two
>> conceptually related changes have resulted in a jump from 1.45 to
>> 1.48. Personally I think this is silly as it means there are version
>> gaps in the CPAN published copies of this code, for instance as far as
>> I can tell the latest version on CPAN is 1.38.
> Again, we don’t need new versions for every commit, just every release.

So every minor version?

Personally i think that is the wrong policy, but I dont care enough to
argue for the alternative. I will stop bumping versions in dist then.

But for the record, i dont seem to be the only one who bumps the
version numbers in their patches.


Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About