develooper Front page | perl.perl5.porters | Postings from February 2018

Re: [perl #131046] [PATCH] Carp: Do not crash when reading @DB::args

Thread Previous | Thread Next
From:
Zefram
Date:
February 24, 2018 01:34
Subject:
Re: [perl #131046] [PATCH] Carp: Do not crash when reading @DB::args
Message ID:
20180224013422.tsf6rkp7wlwrrn4q@fysh.org
demerphq wrote:
>Zefram, that is an uncalled for comment and beneath you.

It is uncalled for to say that there are a couple of problems with
the commit?  Am I misunderstanding what constitutes civility?

>You had weeks to raise these points and chose to stay silent. Next time try
>a different strategy. This pasdive-aggressive say nothing until the patch
>is merged and then ruthlessly criticise what has been merged is not how we
>are supposed to work together.

This was not some ruse to make you look bad.  The reason why I didn't
issue these comments before is that I wasn't aware of your commit message
and the rest until I examined it just now due to it having landed in
blead.  It's true that I missed an opportunity to review it when you
pushed a branch, in that I didn't look at the branch.  I was to some
extent trusting that your commit would reflect the understanding that
you had just expressed.

>From my point of view you didn't drop your objections, you disengaged from
>the process when challenged.

As I recall, I responded repeatedly when you challenged my objections.
I don't see any disengagement there.  The point where I stopped responding
was where you stopped promoting the misconceptions to which I objected.
You switched to a question of taste, on which I had already stated my
opinion, and I had nothing further to add in response to your contrary
opinion.

>That would be the height of rudeness and most inappropriate.

Well, that's part of why I didn't just do it, but floated the idea first.

-zefram

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About