develooper Front page | perl.perl5.porters | Postings from February 2018

[perl #132876] ppport.h breaks croak_xs_usage() on old Perls

From:
Zefram
Date:
February 17, 2018 18:51
Subject:
[perl #132876] ppport.h breaks croak_xs_usage() on old Perls
Message ID:
rt-4.0.24-25919-1518893475-1324.132876-75-0@perl.org
# New Ticket Created by  Zefram 
# Please include the string:  [perl #132876]
# in the subject line of all future correspondence about this issue. 
# <URL: https://rt.perl.org/Ticket/Display.html?id=132876 >



This is a bug report for perl from zefram@fysh.org,
generated with the help of perlbug 1.41 running under perl 5.27.8.


-----------------------------------------------------------------
[Please describe your issue here]

The current version of ppport.h will define croak_xs_usage() if it
is used on a pre-5.10.1 Perl.  This definition takes precedence over
the definition generated by ExtUtils::ParseXS, and so will be used
by generated XS boilerplate code, not just where it is explicitly
called by user code.  However, by default the ppport.h definition
of croak_xs_usage() is broken, referring to an external symbol
"DPPP_my_croak_xs_usage" that is never defined.  This will break almost
any XS code that uses such a recent ppport.h, when compiled with an at
all recent ExtUtils::ParseXS on a pre-5.10.1 Perl.

An individual XS module can avoid this problem by defining the flag macro
"NEED_croak_xs_usage" before #including ppport.h.  This causes ppport.h to
provide a working definition of croak_xs_usage() instead of the default
broken one.  Observe that I applied this workaround to PathTools in
commit 08401071a36d8855d06553b44b678e51d33f09e5, anticipating that it
might get a CPAN release soon and that that release might bundle the
current ppport.h.  (PathTools has an explicit call to croak_xs_usage(),
not just the ones implicit in the XS; this is a red herring.)

Individual XS modules should not have to define this flag macro if they
are not making explicit calls to croak_xs_usage().  ppport.h should not
by default break the code generated by ExtUtils::ParseXS.

[Please do not change anything below this line]
-----------------------------------------------------------------
---
Flags:
    category=library
    severity=medium
    module=Devel::PPPort
---
Site configuration information for perl 5.27.8:

Configured by zefram at Sat Jan 20 03:46:58 GMT 2018.

Summary of my perl5 (revision 5 version 27 subversion 8) configuration:
   
  Platform:
    osname=linux
    osvers=3.16.0-4-amd64
    archname=x86_64-linux-thread-multi
    uname='linux barba.rous.org 3.16.0-4-amd64 #1 smp debian 3.16.43-2+deb8u2 (2017-06-26) x86_64 gnulinux '
    config_args='-des -Dprefix=/home/zefram/usr/perl/perl_install/perl-5.27.8-i64-f52 -Duselargefiles -Dusethreads -Uafs -Ud_csh -Uusesfio -Uusenm -Duseshrplib -Dusedevel -Uversiononly -Ui_db'
    hint=recommended
    useposix=true
    d_sigaction=define
    useithreads=define
    usemultiplicity=define
    use64bitint=define
    use64bitall=define
    uselongdouble=undef
    usemymalloc=n
    default_inc_excludes_dot=define
    bincompat5005=undef
  Compiler:
    cc='cc'
    ccflags ='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2'
    optimize='-O2'
    cppflags='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
    ccversion=''
    gccversion='4.9.2'
    gccosandvers=''
    intsize=4
    longsize=8
    ptrsize=8
    doublesize=8
    byteorder=12345678
    doublekind=3
    d_longlong=define
    longlongsize=8
    d_longdbl=define
    longdblsize=16
    longdblkind=3
    ivtype='long'
    ivsize=8
    nvtype='double'
    nvsize=8
    Off_t='off_t'
    lseeksize=8
    alignbytes=8
    prototype=define
  Linker and Libraries:
    ld='cc'
    ldflags =' -fstack-protector-strong -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/4.9/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
    libs=-lpthread -lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
    perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
    libc=libc-2.19.so
    so=so
    useshrplib=true
    libperl=libperl.so
    gnulibc_version='2.19'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs
    dlext=so
    d_dlsymun=undef
    ccdlflags='-Wl,-E -Wl,-rpath,/home/zefram/usr/perl/perl_install/perl-5.27.8-i64-f52/lib/5.27.8/x86_64-linux-thread-multi/CORE'
    cccdlflags='-fPIC'
    lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'


---
@INC for perl 5.27.8:
    /home/zefram/usr/perl/perl_install/perl-5.27.8-i64-f52/lib/site_perl/5.27.8/x86_64-linux-thread-multi
    /home/zefram/usr/perl/perl_install/perl-5.27.8-i64-f52/lib/site_perl/5.27.8
    /home/zefram/usr/perl/perl_install/perl-5.27.8-i64-f52/lib/5.27.8/x86_64-linux-thread-multi
    /home/zefram/usr/perl/perl_install/perl-5.27.8-i64-f52/lib/5.27.8

---
Environment for perl 5.27.8:
    HOME=/home/zefram
    LANG (unset)
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/home/zefram/usr/perl/perl_install/perl-5.27.8-i64-f52/bin:/home/zefram/usr/perl/util:/home/zefram/pub/x86_64-unknown-linux-gnu/bin:/home/zefram/pub/common/bin:/usr/bin:/bin:/usr/local/bin:/usr/games
    PERL_BADLANG (unset)
    SHELL=/usr/bin/zsh




nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About