develooper Front page | perl.perl5.porters | Postings from February 2018

Re: [Encode] 2.95 released!

Thread Previous | Thread Next
From:
Karl Williamson
Date:
February 8, 2018 17:42
Subject:
Re: [Encode] 2.95 released!
Message ID:
71ef7250-fdb8-e9c5-a123-c9b831f391ca@khwilliamson.com
On 02/08/2018 10:37 AM, Steve Hay wrote:
> On 8 February 2018 at 16:40, Karl Williamson <public@khwilliamson.com> wrote:
>> On 02/08/2018 06:27 AM, Steve Hay via perl5-porters wrote:
>>>
>>> On 8 February 2018 at 00:50, Dan Kogai <dankogai@dan.co.jp> wrote:
>>>>
>>>> Porters,
>>>>
>>>> Just VERSION++’ed Encode.  It's basically a release version of:
>>>>
>>>> https://github.com/dankogai/p5-encode/pull/128
>>>>
>>>> by khwilliamson.
>>>>
>>>
>>> I think it will cause porting tests to fail in blead because
>>> Unicode.xs is changed but Unicode.pm isn't VERSION++'ed.
>>>
>>> Also, encoding.pm has a tiny difference compared to blead but isn't
>>> VERSION++'ed either.
>>>
>>
>> What I sent to Dan passed all tests in the p5p test suite.  I don't know
>> what he may have changed before releasing
> 
> I've just given it a whirl (using the attached patch) and as predicted
> I find porting/cmp_version.t fails two tests:
> 
> C:\Dev\Git\perl\t>.\perl harness porting\cmp_version.t
> porting/cmp_version.t .. 1/79 # not ok 2 -
> cpan/Encode/Unicode/Unicode.pm version 2.16
> porting/cmp_version.t .. 2/79 # not ok 3 - cpan/Encode/encoding.pm version 2.21
> porting/cmp_version.t .. Failed 2/79 subtests
> 
> Test Summary Report
> -------------------
> porting/cmp_version.t (Wstat: 0 Tests: 79 Failed: 2)
>    Failed tests:  2-3
> Files=1, Tests=79, 10 wallclock secs ( 0.06 usr +  0.00 sys =  0.06 CPU)
> Result: FAIL
> 


So what to do.  Create a customized blead version?

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About