develooper Front page | perl.perl5.porters | Postings from February 2018

Re: [perl #132810] Blead Breaks CPAN:KYZ/Test-MockCommand-0.03.tar.gz

Thread Previous | Thread Next
From:
Leon Timmermans
Date:
February 4, 2018 21:14
Subject:
Re: [perl #132810] Blead Breaks CPAN:KYZ/Test-MockCommand-0.03.tar.gz
Message ID:
CAHhgV8hK3-WN30kFD2dzokjCp9vmixonmQbNVG+KRDdN0FpJ+g@mail.gmail.com
On Sun, Feb 4, 2018 at 7:34 PM, Slaven Rezic <slaven@rezic.de> wrote:
>>>
>>>
>>
>> Bisection points to:
>>
>> #####
>> 397baf232086e0a9ad6f881a9614d3dbaea853fc is the first bad commit
>> commit 397baf232086e0a9ad6f881a9614d3dbaea853fc
>> Author: Zefram <zefram@fysh.org>
>> Date:   Tue Dec 12 06:24:01 2017 +0000
>>
>>     properly check readpipe()'s argument list
>>
>>     readpipe() wasn't applying context to its argument list, resulting in
>>     readpipe()'s context leaking in, and broken stack discipline when a list
>>     expression was used.  Fixes [perl #4574].
>>

This essentially changed the prototype of a keyword. I don't think
that sort of breaking change should happen without a proper discussion
about it.

I don't mind breaking broken code, but I see to reason to break code
that had been working fine for 20+ years. It seems to me we can fix
this in less painful ways.

Leon

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About