Front page | perl.perl5.porters |
Postings from January 2018
On Wed, 31 Jan 2018 14:57:32 GMT, jkeenan wrote:
> On Tue, 30 Jan 2018 07:13:47 GMT, zefram@fysh.org wrote:
> > slaven@rezic.de wrote:
> > >The test t/03-Universal-Override.t in Object-Trampoline-1.42
> > >fails with 5.27.7 and 5.27.8, and was OK until 5.27.6:
> >
> > Bisects to commit 915a6810d3e3198d759f025f85d1fd6f3171dd27 "Carp: optimize
> > format_arg when arguments contain many references". The issue is that
> > the new Carp code in that commit refers to $UNIVERSAL::isa::VERSION, and
> > so vivifies $UNIVERSAL::{"isa::"}. The test iterates over %UNIVERSAL::,
> > using each key found as a method name, and isn't prepared for there to
> > be a key that doesn't syntactically behave as a method name.
> >
> > The test is erroneous in using all keys it finds as method names.
> > It should skip ones that aren't syntactically OK.
> >
> > The edit to Carp is also arguably faulty. In other areas Carp goes
> > to significant effort to avoid vivifying stash entries that it doesn't
> > intend to. It should probably apply similar logic in this search for
> > &UNIVERSAL::isa.
> >
> > -zefram
>
> Are you saying we should apply something like the patch attached?
>
> Thank you very much.
In the branch, to avert a test failure I have also incremented $Carp::Heavy::VERSION.
--
James E Keenan (jkeenan@cpan.org)
---
via perlbug: queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=132788
Thread Previous
|
Thread Next