develooper Front page | perl.perl5.porters | Postings from January 2018

Re: [perl #132783] Blead Breaks CPAN: ADAMK/SQL-String-0.02.tar.gz

Thread Previous | Thread Next
From:
Dave Mitchell
Date:
January 30, 2018 15:38
Subject:
Re: [perl #132783] Blead Breaks CPAN: ADAMK/SQL-String-0.02.tar.gz
Message ID:
20180130153827.GE3081@iabyn.com
On Tue, Jan 30, 2018 at 01:03:23AM -0800, Sergey Aleynikov via RT wrote:
> On Mon, 29 Jan 2018 12:25:24 -0800, slaven@rezic.de wrote:
> > The test suite of SQL-String-0.02 started to fail with 5.27.7
> > (there's no bisect result yet):
> 
> Bisect points to
> 
> d7e75038064881b413f76de9315a5acfb21472f0 is the first bad commit
> commit d7e75038064881b413f76de9315a5acfb21472f0
> Author: David Mitchell <davem@iabyn.com>
> Date:   Tue Nov 28 09:08:09 2017 +0000
> 
>     $overloaded .= $x: don't stringify $x
> 
>     RT #132385
> 
>     This is a variant of the ($ref . $overloaded) bug which was fixed with
>     v5.27.5-195-gb3ab0375cb.
> 
>     Basically, when the overloaded concat method is called, it should pass
>     $x as-is, rather than as "$x". This fixes PDL-2.018

The test case reduces to

    use warnings;
    package Foo { use overload '.=' => sub  { return "foo"; }; }
    my $s = bless [], 'Foo';
    my $x;
    $s .= $x;

which used to be silent, but now emits:

    Use of uninitialized value $x in concatenation (.) or string

I'll look into this further when I can find some time.




-- 
No man treats a motor car as foolishly as he treats another human being.
When the car will not go, he does not attribute its annoying behaviour to
sin, he does not say, You are a wicked motorcar, and I shall not give you
any more petrol until you go. He attempts to find out what is wrong and
set it right.
    -- Bertrand Russell,
       Has Religion Made Useful Contributions to Civilization?

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About