develooper Front page | perl.perl5.porters | Postings from January 2018

Re: [perl #132761] [PATCH] Devel::PPPort for older Perl versions

Thread Previous | Thread Next
From:
pali
Date:
January 25, 2018 08:30
Subject:
Re: [perl #132761] [PATCH] Devel::PPPort for older Perl versions
Message ID:
20180125083013.GA27332@pali
On Wednesday 24 January 2018 19:41:02 Tony Cook via RT wrote:
> From 0874dc6ed2d15e8e4ca523016101cb80c200a163 Mon Sep 17 00:00:00 2001
> From: Tony Cook <tony@develop-help.com>
> Date: Thu, 25 Jan 2018 14:39:54 +1100
> Subject: (perl #132761) croak_xs_usage() shouldn't accept a THX arguement
> 
> ---
>  dist/Devel-PPPort/parts/inc/mess | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/dist/Devel-PPPort/parts/inc/mess b/dist/Devel-PPPort/parts/inc/mess
> index 9ef95cf889..e916ea7792 100644
> --- a/dist/Devel-PPPort/parts/inc/mess
> +++ b/dist/Devel-PPPort/parts/inc/mess
> @@ -206,7 +206,7 @@ mess_sv(pTHX_ SV *basemsg, bool consume)
>  #ifndef croak_xs_usage
>  #if { NEED croak_xs_usage }
>  void
> -croak_xs_usage(pTHX_ const CV *const cv, const char *const params)
> +croak_xs_usage(const CV *const cv, const char *const params)
>  {
>      const GV *const gv = CvGV(cv);

Does not CvGV need to declare dTHX; when pTHX_ is not supplied as
argument?

>  
> -- 
> 2.11.0
> 

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About