develooper Front page | perl.perl5.porters | Postings from December 2017

Re: [perl #132646] Bleadperl v5.27.6-120-gbcc30fd027 breaksGARU/Data-Printer-0.40.tar.gz

Thread Previous | Thread Next
From:
Dave Mitchell
Date:
December 25, 2017 11:44
Subject:
Re: [perl #132646] Bleadperl v5.27.6-120-gbcc30fd027 breaksGARU/Data-Printer-0.40.tar.gz
Message ID:
20171225114401.GA4099@iabyn.com
On Sat, Dec 23, 2017 at 04:11:25AM -0800, Andreas J. Koenig via RT wrote:
> commit bcc30fd0276e8f6d4ac27d6f4c719b70a266b1fc
> Author: David Mitchell <davem@iabyn.com>
> Date:   Mon Dec 4 11:50:53 2017 +0000
> 
>     multiconcat: don't fold adjacent constants
> 
> diagnostics
> -----------
> http://www.cpantesters.org/cpan/report/82741a38-d967-11e7-9af2-f32bb5d65ef4

Now fixed:

commit f08f2d0393c6f2ccdfc17ed791cd9956d95eaa4e
Author:     David Mitchell <davem@iabyn.com>
AuthorDate: Mon Dec 25 10:40:58 2017 +0000
Commit:     David Mitchell <davem@iabyn.com>
CommitDate: Mon Dec 25 11:21:07 2017 +0000

    mutlitconcat: fix non-folding adjacent consts
    
    RT ##132646
    
    v5.27.6-120-gbcc30fd changed multiconcat so that adjacent constants
    weren't folded, so that ($overloaded . "a" . "b") is invoked as
        $overloaded->concat("a")->concat("b")
    rather than
        $overloaded->concat("ab")
    
    It did this by 'demoting' every second adjacent const as a real arg rather
    than adding it to the const string. However, that could leave a
    multiconcat op with more than the maximum allowed args.
    
    So include demotion candidates as part of the arg count.


-- 
More than any other time in history, mankind faces a crossroads. One path
leads to despair and utter hopelessness. The other, to total extinction.
Let us pray we have the wisdom to choose correctly.
    -- Woody Allen

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About