develooper Front page | perl.perl5.porters | Postings from December 2017

Re: [perl.git] branch blead updated. v5.27.6-156-g5d4548b73b

Thread Previous | Thread Next
From:
demerphq
Date:
December 8, 2017 08:07
Subject:
Re: [perl.git] branch blead updated. v5.27.6-156-g5d4548b73b
Message ID:
CANgJU+UtbNGcr9116uQn86PoURUOhp5PQ=BcAEtjN+NNt06=pA@mail.gmail.com
Thank you for the fix, how did this come to your attention? Did I miss a
warning?

Also, I suspect that the change is actually wrong, if only because of my
stupidity in calling it _qq. It was doing single quote quoting, with
minimal escapes, deliberately. It should have been called _sq. We don't
want the output excessively escaped, the point is to make it possible to
cut and paste the output into perldelta.pod without further modification.

Anyway, I'll follow up on this.

Yves



On 8 Dec 2017 01:16, "Zefram" <zefram@fysh.org> wrote:

> In perl.git, the branch blead has been updated
>
> <https://perl5.git.perl.org/perl.git/commitdiff/
> 5d4548b73b1d6298ebeef6d93e510cc249106b85?hp=19a498a461d7c81ae3507c450953d1
> 148efecf4f>
>
> - Log -----------------------------------------------------------------
> commit 5d4548b73b1d6298ebeef6d93e510cc249106b85
> Author: Zefram <zefram@fysh.org>
> Date:   Fri Dec 8 00:11:59 2017 +0000
>
>     delete duplicate _qq from test
>
>     Commit af05e4c0b428a803fcdb60c956b1da7ff8a95926 added a _qq() sub
>     to t/re/reg_mesg.t that duplicates both the intent and the name of
>     t/test.pl's _qq(), causing a redefinition warning.  Remove the new
> _qq(),
>     because t/test.pl's version is better.
>
> commit 9291839cdbaa256b811274b66910a960a7f3b06d
> Author: Zefram <zefram@fysh.org>
> Date:   Fri Dec 8 00:03:16 2017 +0000
>
>     assert min identifier length in S_pending_ident()
>
> -----------------------------------------------------------------------
>
> Summary of changes:
>  t/re/reg_mesg.t | 8 --------
>  toke.c          | 1 +
>  2 files changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/t/re/reg_mesg.t b/t/re/reg_mesg.t
> index 24cd986960..2e3ed07ff7 100644
> --- a/t/re/reg_mesg.t
> +++ b/t/re/reg_mesg.t
> @@ -65,14 +65,6 @@ sub add_markers {
>      return $element;
>  }
>
> -sub _qq {
> -    my ($str)= @_;
> -    $str =~ s/\\/\\\\/g;
> -    $str =~ s/\$/\\\$/g;
> -    return qq("$str");
> -}
> -
> -
>  ## Because we don't "use utf8" in this file, we need to do some extra
> legwork
>  ## for the utf8 tests: Prepend 'use utf8' to the pattern, and mark the
> strings
>  ## to check against as UTF-8, but for this all to work properly, the
> character
> diff --git a/toke.c b/toke.c
> index 5aeec6fc65..a4150c2f05 100644
> --- a/toke.c
> +++ b/toke.c
> @@ -8943,6 +8943,7 @@ S_pending_ident(pTHX)
>
>      DEBUG_T({ PerlIO_printf(Perl_debug_log,
>            "### Pending identifier '%s'\n", PL_tokenbuf); });
> +    assert(tokenbuf_len >= 2);
>
>      /* if we're in a my(), we can't allow dynamics here.
>         $foo'bar has already been turned into $foo::bar, so
>
> --
> Perl5 Master Repository
>

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About