[perl #132483] BBC: recent commit breaks App::perlbrew

On Wed, 22 Nov 2017 17:00:24 GMT, atoomic@cpan.org wrote:
> The App::perlbrew code is expecting that any stash entry points to a
> GV, whereas now since 5.27.ish it can be a simple CV...
> The code from App::perlbrew::commands sub needs some easy tweak.
> 
> I suspect that this might not be the only module expecting a GV for a
> stash entry...
> We will probably discover more Modules over time that need similar
> patch.
> 
> I've submitted upstream ( App::perlbrew repo a fix for it)
> https://github.com/gugod/App-perlbrew/pull/581
> 
> I think we should close this ticket as this an upstream issue.
> 
> thanks
> nicolas
> 


> On Wed, 22 Nov 2017 08:10:24 -0800, atoomic@cpan.org wrote:
> > Thanks, James & Dave, after a git bisect on my side it appears that
> > it
> > comes from commit d96402565ccd7459d3a8bc4074f177d00bbefeeb
> > can you confirm that you are viewing the same offending commit?
> >
> > ___
> > Bisecting: 87 revisions left to test after this (roughly 7 steps)
> > [2ac5cb3d95aef19c0451b99cd61a1b979dacd58f] Bump version of B/O.pm to
> > 1.03
> >
> > https://github.com/p5h/perl5demo/commit/d96402565ccd7459d3a8bc4074f177d00bbefeeb
> >
> > ...
> >
> > d96402565ccd7459d3a8bc4074f177d00bbefeeb is the first bad commit
> > commit d96402565ccd7459d3a8bc4074f177d00bbefeeb
> > Author: Father Chrysostomos <sprout@cpan.org>
> > Date:   Sun Oct 29 11:21:45 2017 -0700
> >
> > Revert "Temporarily revert CV-in-stash optimisation"
> >
> > This reverts commit 6eed25e2537643b77650cb3e4514ec9dc2e97d74.
> >
> > :100644 100644 c61bfd08deb1ff7fc5f0795f180adebd635862c0
> > 368f9b146e6284750fa9949a77a88d26e76c2a74 M      op.c
> > :040000 040000 c3bc134118d6dfd1e02aaf2106045d59bc65ed60
> > 4f56c0f0c1873c14139cfdc0d2dc95e219aabda2 M      t
> >
> > On Wed, 22 Nov 2017 03:34:24 -0800, davem wrote:
> > > On Tue, Nov 21, 2017 at 06:40:46PM -0800, James E Keenan wrote:
> > > > CPAN module App::perlbrew is broken in blead.  The breakage,
> > > > which
> > > > occurred this month, started somewhere *after*
> > > > b3937e202aaf10c2f8996e2993c880bb38a7a268^ and at or before
> > > > a1c09dad0dcf10a829797ed9862b81e1b7497f18.
> > >
> > > To save people looking, that's 177 commits in the range
> > >    v5.27.5-181-gb3937e2
> > > to v5.27.5-357-ga1c09da
> > >
> > >
> > >


Nicolas, Dave M, thanks for that analysis.  I'm reluctant to close this ticket at this time because I suspect that the number of CPAN distros that will have to modify their code to accommodate this change will be significant.  I have confirmed that MOP is now failing against blead, as is QBit-WebInterface (though that is obscured by absence of an upstream C library).

While I don't think that the amount of repair work to be done on CPAN will be as great as, say, that needed for no-dot-in-@INC in perl-5.26.0, that work will still be significant.

I wonder whether the commit(s) which triggered these failures was absolutely necessary -- but I don't claim to understand those issues well enough.

Thank you very much.


-- 
James E Keenan (jkeenan@cpan.org)

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=132483

• [perl #132483] BBC: recent commit breaks App::perlbrew by James E Keenan
• Re: [perl #132483] BBC: recent commit breaks App::perlbrew by Sawyer X
• Re: [perl #132483] BBC: recent commit breaks App::perlbrew by Dave Mitchell
• [perl #132483] BBC: recent commit breaks App::perlbrew by Father Chrysostomos via RT
• Re: [perl #132483] BBC: recent commit breaks App::perlbrew by Dave Mitchell
• [perl #132483] BBC: recent commit breaks App::perlbrew by James E Keenan via RT