develooper Front page | perl.perl5.porters | Postings from October 2017

[perl #132276] [PATCH] Use library functions instead of manual TAPin t/io/tell.t

Thread Previous
From:
James E Keenan via RT
Date:
October 12, 2017 20:43
Subject:
[perl #132276] [PATCH] Use library functions instead of manual TAPin t/io/tell.t
Message ID:
rt-4.0.24-15005-1507841025-100.132276-15-0@perl.org
On Thu, 12 Oct 2017 13:38:38 GMT, dmitry.ulanov@booking.com wrote:
> This is a bug report for perl from dmitry.ulanov@booking.com,
> generated with the help of perlbug 1.40 running under perl 5.27.5.
> 
> 
> -----------------------------------------------------------------
> [Please describe your issue here]
> Use library functions instead of manual TAP in t/io/tell.t
> https://perl5.git.perl.org/perl.git/blob/refs/heads/blead:/Porting/todo.pod#l50
> 
> 

While I agree that t/io/tell.t falls under the rubric of the Porting/todo.pod "Migrate t/ from custom TAP generation" suggestion, I don't believe this patch should be applied as is.

If we're going to reformulate each unit test in this file, then we should provide descriptions for each such test, viz., a 2nd argument for ok() and a 3rd argument for is().  (See, e.g., t/io/argv.t.)  Otherwise, we will continue to have only a string of 'ok' and 'not ok' statements without any description as to what each test is doing.

Can you re-work?

Thank you very much.

-- 
James E Keenan (jkeenan@cpan.org)

---
via perlbug:  queue: perl5 status: new
https://rt.perl.org/Ticket/Display.html?id=132276

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About