Front page | perl.perl5.porters |
Postings from September 2017
Re: [PATCHES] Tie::StdHandle::BINMODE and "use" docs
Thread Previous
|
Thread Next
From:
Hauke D
Date:
September 26, 2017 10:29
Subject:
Re: [PATCHES] Tie::StdHandle::BINMODE and "use" docs
Message ID:
07d178f1-cc4b-e315-7d21-2071f9b51326@zero-g.net
Hi,
Sorry, I have to withdraw the second of my four patches, the one that
modifies Tie::StdHandle::WRITE, as it causes "print {$tiedhandle} '';"
to return false when it should not (the other patches should still apply
though). The fix is to modify PRINT and PRINTF as well, as I did in my
class here:
https://bitbucket.org/haukex/file-replace/src/HEAD/lib/Tie/Handle/Base.pm
But before I start trying to give Tie::Handle and Tie::StdHandle a
makeover and spamming you with more patches, I was wondering if there is
an interest in me doing so?
The only real problem I see with Tie::StdHandle at the moment is BINMODE
not handling the layer argument (my first patch). Whether WRITE not
returning the length of the data is acceptable or not is probably
debatable. For that, the above class is basically my replacement for
Tie::StdHandle.
Thanks, Regards,
-- Hauke D
On 22.09.2017 14:36, Hauke D wrote:
> Hi all,
>
> Bump - with updated patches:
>
> 1. Fix Tie::StdHandle::BINMODE's handling of the "layer" argument, was
> previously two separate patches (fix+tests), now squashed into one.
>
> 2. Change Tie::StdHandle::WRITE to return the length of the data
> written, to bring it more into line with syswrite.
>
> 3. Bump Tie::StdHandle version
>
> 4. The previously proposed doc change, but with a long line error fixed
> (reported by t/porting/podcheck.t)
>
> The patches are also rebased onto the current blead, but there were no
> conflicts anyway. All tests pass successfully with a standard
> configuration on Linux.
>
> (Note: 1. and 2. are based on my work on Tie::Handle::Base:
> http://cpansearch.perl.org/src/HAUKEX/File-Replace-0.04/lib/Tie/Handle/Base.pm
> )
>
> Regards,
> -- Hauke D
>
>
> On 09.09.2017 12:50, Hauke D wrote:
>> Dear P5P,
>>
>> It was nice to see some of you in Amsterdam, even if we didn't get a
>> chance to meet personally - this was my first Perl event, so hopefully
>> next time :-)
>>
>> Attached are two simple patches, since they're only one line each I
>> didn't submit them via perlbug, but can do that if desired.
>>
>> First is a patch for Tie::StdHandle::BINMODE not handling the "LAYER"
>> argument, second is a nitpick of the documentation of "use Module
>> 12.34;", which adds the implicit Module->import() call to the
>> "equivalent" code.
>>
>> Thanks, Regards,
>> -- Hauke D
Thread Previous
|
Thread Next