develooper Front page | perl.perl5.porters | Postings from September 2017

[perl #132153] perl-5.26.1/doio.c:1529]: (style) Suspiciouscondition

Thread Previous
From:
James E Keenan via RT
Date:
September 24, 2017 02:13
Subject:
[perl #132153] perl-5.26.1/doio.c:1529]: (style) Suspiciouscondition
Message ID:
rt-4.0.24-32058-1506219225-703.132153-15-0@perl.org
On Sat, 23 Sep 2017 22:43:07 GMT, dcb314@hotmail.com wrote:
> Hello there,
> 
> 
> perl-5.26.1/doio.c:1529]: (style) Suspicious condition (assignment +
> comparison); Clarify expression with parentheses.
> 
> 
> Source code is
> 
> 
> if ( (  (SvROK(sv) && (  isGV_with_GP(SvRV(sv))
>                       || (isio = SvTYPE(SvRV(sv)) == SVt_PVIO)  )
> 
> 
> Maybe better code
> 
> 
> if ( (  (SvROK(sv) && (  isGV_with_GP(SvRV(sv))
>                       || ((isio = SvTYPE(SvRV(sv))) == SVt_PVIO)  )
> 
> 
> Regards
> 
> 
> David Binderman

Can you provide (as an attachment) the output of 'perl -V' for the perl build that generated this warning?

We will, in particular, be looking for information on the C compiler you used for 'make' and the operating system on which you are running.

Thank you very much.



-- 
James E Keenan (jkeenan@cpan.org)

---
via perlbug:  queue: perl5 status: new
https://rt.perl.org/Ticket/Display.html?id=132153

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About