develooper Front page | perl.perl5.porters | Postings from September 2017

Re: [PATCHES] Tie::StdHandle::BINMODE and "use" docs

Thread Previous | Thread Next
Hauke D
September 9, 2017 12:45
Re: [PATCHES] Tie::StdHandle::BINMODE and "use" docs
Message ID:

On 09.09.2017 13:39, James E Keenan wrote:
 > This should be accompanied by a test file which demonstrates that,
 > before the patch is applied, a problem is present, and then after the
 > patch is applied, the problem is corrected.

Yes, sorry, I had tested it locally but should have included a test 
file, now attached. This is on Perl 5.26.0 on Linux.

Also attached is another patch for lib/Tie/Handle/stdhandle.t that tests 
the fix. Tested on blead, both original (where the test fails) and 
patched (where the test passes).

On 09.09.2017 13:48, James E Keenan wrote:
 > What is strange timestamp in line above?  It occurs in both patches.

I don't know, those files are exactly as generated by "git 
format-patch". It did it for the new patch too :-/

Thanks, Regards,
-- Hauke D

Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About