Front page | perl.perl5.porters |
Postings from September 2017
On 09/09/2017 06:50 AM, Hauke D wrote:
> Dear P5P,
>
> It was nice to see some of you in Amsterdam, even if we didn't get a
> chance to meet personally - this was my first Perl event, so hopefully
> next time :-)
>
> Attached are two simple patches, since they're only one line each I
> didn't submit them via perlbug, but can do that if desired.
>
> First is a patch for Tie::StdHandle::BINMODE not handling the "LAYER"
> argument, second is a nitpick of the documentation of "use Module
> 12.34;", which adds the implicit Module->import() call to the
> "equivalent" code.
> [snip]
From c52ddfac3fe5ca4346b21376d12327cccf14e169 Mon Sep 17 00:00:00 2001
From: Hauke D <haukex@zero-g.net>
Date: Sat, 9 Sep 2017 12:12:10 +0200
Subject: [PATCH 1/2] Tie::StdHandle::BINMODE: handle layer argument
BINMODE was not handling the LAYER argument.
---
lib/Tie/StdHandle.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Tie/StdHandle.pm b/lib/Tie/StdHandle.pm
index 0c58b706e4..d2a1aab717 100644
--- a/lib/Tie/StdHandle.pm
+++ b/lib/Tie/StdHandle.pm
@@ -49,7 +49,7 @@ sub TELL { tell($_[0]) }
sub FILENO { fileno($_[0]) }
sub SEEK { seek($_[0],$_[1],$_[2]) }
sub CLOSE { close($_[0]) }
-sub BINMODE { binmode($_[0]) }
+sub BINMODE { &CORE::binmode(shift, @_) }
sub OPEN
{
--
2.14.1
This should be accompanied by a test file which demonstrates that,
before the patch is applied, a problem is present, and then after the
patch is applied, the problem is corrected.
Thank you very much.
Jim Keenan
Thread Previous
|
Thread Next