develooper Front page | perl.perl5.porters | Postings from August 2017

Re: cv_get_call_checker_flags()

Thread Previous | Thread Next
Father Chrysostomos
August 9, 2017 02:22
Re: cv_get_call_checker_flags()
Message ID:
Zefram wrote:
> The patch that added cv_set_call_checker_flags() back in 5.21.4 was
> conspicuously missing a corresponding cv_get_call_checker_flags().
> I've just added it in commit 71c697dea4f5a96ca9a9867eef07455c74f502f5.
> Please raise any doubts about the API now.

I do not quite understand the logic for reversing the flag here:

+If the C<CALL_CHECKER_REQUIRE_GV> bit is set in C<gflags> then it
+indicates that the caller only knows about the genuine GV version of
+C<namegv>, and accordingly the corresponding bit will always be set in
+C<*ckflags_p>, regardless of the check function's recorded requirements.

I would expect a flag being *on* to indicate that the caller under-
stands the flag, but this would be moot, since any caller new enough
to know about this API should know about that flag.

Could you clarify?  Why does this flag need to be in reverse?  Does it
indicate that future flags will also be in reverse?

Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About