On Mon, May 22, 2017 at 11:34:42AM +0200, Sawyer X wrote: > On 05/21/2017 06:08 AM, Karl Williamson wrote: > > I think that there is still a bunch of sloppiness in perldelta which > > would not reflect well on us as a project with our act together if it > > is released without being cleaned up. > > utf8_hop_safe() does not belong where it currently is, under "Core > > Enhancements". There are lots more functions and macros added in this > > release for the same "_safe" purpose, and they are listed later, under > > "Internal Changes". I'm thinking there should be a section like > > "Internal API Enhancements" or "XS API Enhancements" > > That would be useful. We can also put such changes at the end of the > "Internal Changes." It's difficult to determine what *should* or > *shouldn't* go under that category since it's broad. Perhaps that's the > value of it. I've just just pushed a bunch of perldelta commits that (hopefully) address the issues noted by Karl, both here and in his various commit messages. In particular: Moved utf8_hop_safe() to Internals Removed an entry about a 5.23.5 regression (it was actually a 5.25.3 regression). Re-ordered "Core Enhancements" entries based on my subjective judgement of importance. Removed some "Internal Changes" entries which I didn't think needed documenting - usually we only document API changes or significant changes to guts. Moved some entries from "Core Enhancements" to "Bug Fixes" Sorted "Internal Changes" to group similar entries together Took all the Unicode/utf8 entries in "Internal Changes" and made them into their own =over/=back subsection. Then added lots of missing entries: previously there was just a vague "Several macros and functions have been added to the public API" without enumerating them. Karl, it might be particularly productive for you to give that new subsection a quick review - it's mostly based on the things you've added to the API, and I may have misunderstood bits of it: =item * Several new macros and functions for dealing with Unicode and UTF-8-encoded strings have been added to the API, as well some changes in functionality of existing functions (see L<perlapi/Unicode Support> for more details): =over XXX lots of stuff added by me here =back -- My Dad used to say 'always fight fire with fire', which is probably why he got thrown out of the fire brigade.Thread Previous | Thread Next