On 05/18/2017 09:31 PM, Karl Williamson wrote: > On 05/17/2017 11:17 PM, Karl Williamson wrote: >> On 05/17/2017 08:54 AM, Ævar Arnfjörð Bjarmason wrote: >>> On Wed, May 17, 2017 at 4:32 PM, Karl Williamson >>> <public@khwilliamson.com> wrote: >>>> On 05/17/2017 07:16 AM, Dave Mitchell wrote: >>>>> >>>>> On Tue, May 16, 2017 at 04:13:33PM +0200, Sawyer X wrote: >>>>>>> >>>>>>> Are you in a position to be able to coalesce soon? If not I could >>>>>>> have a >>>>>>> go. >>>>> >>>>> >>>>>> Also, worth noting: I *have* coalesced them, just with some mistakes. >>>>>> Feel free to add it yourself to perldelta directly. >>>>> >>>>> >>>>> Yeah sorry, I realised that later - I must have been looking at the >>>>> wrong >>>>> branch when I saw an emptyish perldelta. >>>>> >>>>>> I'll do it today/tomorrow. I have additional cleanups to do. We will >>>>>> have another RC soon, so I think by then we'll have ironed out >>>>>> everything. >>>>>> >>>>>> If you find anything else, please let me know. I'll go over it >>>>>> again and >>>>>> again, hopefully cleaning it up properly. >>>>>> >>>>>> Would you like me to merge your text? >>>>> >>>>> >>>>> I'd suggest that first, Ævar merges his branch as-is (any bikeshedding >>>>> of it can be accommodated with further commits to blead rather than >>>>> updating a separate branch). >>>>> >>>>> Then I'll merge in my @INC text, >>>>> >>>>> Then people can tweak anything as they see fit. >>>>> >>>>> ? >>>>> >>>> >>>> +1 >>> >>> I've just done that. Yves had a patch on top which I squashed into >>> mine and changed him to be the author (since the text was all his at >>> that point), sans a typo in a commit message and a minor whitespace >>> fix what I pushed was what I noted above. >>> >>> Thanks everyone for the feedback! >>> >> >> I have made some updates to perldelta, but have run out of time tonight. >> There's a lot more work needed than I realized. >> >> The commit messages indicate things I hope others will look at. >> > > > I pushed a couple of nits fixes. I'm only about 10% of the way through > the file. > I've pushed a few more changes, stopping when my eyes started to glaze over reading the thing. I believe the section on documentation changes needs extensive changes. The stuff in there is mostly useless. "Removed redundand dSP from an example" may be true, but its not really useful. And specifying these would lead a reader to think that the section really is extremely detailed and accurate, whereas, what is in it is kind of random. The rewrite of the first part of perlre and removal of the final part were not mentioned at all, and are far more important than most of what is in there. If we are going to have this section, the various pod files should be examined for commits that occurred in this release. I would go to the history links like https://perl5.git.perl.org/perl.git/history/HEAD:/pod/perlre.podThread Previous | Thread Next