On 05/14/2017 12:33 AM, Ævar Arnfjörð Bjarmason wrote: > On Thu, May 11, 2017 at 7:21 PM, Sawyer X <xsawyerx@gmail.com> wrote: >> perl-5.26.0's official release will occur on May 20th, 2017, assuming >> all goes well(tm). > As someone with no contributions to this release[1] I thought I was in > a good position to see if the perldelta made sense to someone with no > real idea of what was going on in 5.26. That's a contribution. :) > > I've pushed avar/v5.26.0-RC1-perldelta-fixes which has proposed fixes > to the document: > https://github.com/Perl/perl5/compare/blead...avar/v5.26.0-RC1-perldelta-fixes Thank you! > > The tip of that branch are a bunch of "TODO perldelta: *" commits > where I don't know what should be said, but think that something > should be clarified/fixed by others who actually know what these > entries are referring to. > > I think it would be uncontroversial to push the non-TODO commits to > blead, but haven't because at this stage in the release everything > should probably get reviewed. I'm reproducing the diff of the TODO > commits below for convenience: > > diff --git a/pod/perldelta.pod b/pod/perldelta.pod > index 06f68311fb..c8dc2b81a3 100644 > --- a/pod/perldelta.pod > +++ b/pod/perldelta.pod > @@ -82,6 +82,11 @@ C<%{^CAPTURE}> is the equivalent to C<%+> (ie named captures) > > C<%{^CAPTURE_ALL}> is the equivalent to C<%-> (ie all named captures). > > + ^ This really needs a note about what this is actually for. Is it > + just so you can get an array of all matched params? Why would you > + use a more verbose synonym like %{^CAPTURE} instead of %+ in your > + code? That's a good addition to have. > + > =head2 Unicode 9.0 is now supported > > A list of changes is at L<http://www.unicode.org/versions/Unicode9.0.0/>. > @@ -195,6 +200,12 @@ the end of the supplied buffer. > For security reasons, C<@INC> no longer contains the default directory > (C<.>). > > + Why are we mentioning this both here and in the main section > + (maybe not an issue), but most importantly isn't this wrong? > + don't we have . in @INC now unless you opt-in via > + -Ddefault_inc_excludes_dot? If not the main section above > + needs changing. I think the suggestion you had later in the thread addresses it. +1 to that. > + > =head2 "Escaped" colons and relative paths in PATH > > On Unix systems, Perl treats any relative paths in the PATH environment > @@ -283,6 +294,9 @@ ones which weren't have been improved. > > Several other ops may now also be faster in boolean context. > > + Could we be a bit less vague here? Arithmetic ops? stuff like > + print, what? Dave? > + > =item * New Faster Hash Function on 64 bit builds > > We use a different hash function for short and long keys. This should > @@ -327,6 +341,11 @@ Enhancements in Regex concat COW implementation. > > Speed up C<AV> and C<HV> clearing/undeffing. > > + Does this mean that `undef %h` and `undef @a` are faster, or is it > + for some reason only the internal XS stuff? If it's the former > + (which I assume) let's use the more readable forms someone not > + deep into XS will know about. > + Makes sense. Suggestions on phrasing? > =item * > > Better optimise array and hash assignment > @@ -1634,6 +1653,9 @@ tests for perlbug. [perl #128020] > > C<DEFAULT_INC_EXCLUDES_DOT> has been turned on as default. > > + Again, wasn't this off now by default per the intro section > + talking about -Ddefault_inc_excludes_dot? > + Yup. Thank you for doing this AEvar.Thread Previous | Thread Next