Front page | perl.perl5.porters |
Postings from March 2017
On Tue, Mar 21, 2017 at 09:17:17PM +0100, Sawyer X wrote:
>
>
> On 03/21/2017 12:51 PM, Graham Knop wrote:
> > On Mon, Mar 20, 2017 at 4:37 PM, James E Keenan via RT
> > <perlbug-followup@perl.org> wrote:
> >> On Mon, 20 Mar 2017 12:53:42 GMT, davem wrote:
> >>> On Mon, Dec 26, 2016 at 06:07:55PM +0100, Sawyer X wrote:
> >>>> These were all merged but I think we should remove them in favor of
> >>>> the
> >>>> upcoming revised patch (based on Chris' comments) by Aristotle, work
> >>>> in
> >>>> progress is on ap/baseincguard.
> >>> Are we still planning to do this for 5.26.0? If not, can this ticket
> >>> be removed from the blockers list?
> >> My vote would be to remove it from the blockers list. Even if the work in the ap/baseincguard were to be completed, there's not sufficient time to test it against CPAN before full code freeze.
> >>
> >> But this is a pumpking's call.
> >>
> >> Thank you very much.
> > Can't we just revert the base.pm changes without putting anything
> > extra in place? We're already removing . from @INC globally. There's
> > little need for base.pm to have its own protections, especially given
> > how broken the current implementation is.
>
> This makes sense.
>
> I spoke to Graham more about this on #p5p. There's no need to have an
> altered base.pm with 5.26.0 (because safe @INC is turned on by default
> anyway). When base.pm is released separately, it will simply be a
> different (and up-to-date) version.
>
> So we should undo the changes to base.pm in blead. Post 5.26 we could
> sync it with CPAN.
I've just pushed the following 3 commits:
commit 6ee05a9b9195a324347204414de1405b2b0771e3
Author: David Mitchell <davem@iabyn.com>
AuthorDate: Fri Mar 24 08:10:12 2017 +0000
Commit: David Mitchell <davem@iabyn.com>
CommitDate: Fri Mar 24 08:34:06 2017 +0000
Revert base.pm's dot-in-INC changes.
This reverts:
458470f62360040dcd4b5a55c8ba07503e1af5fc
362f3f748cb84934a072fadbfb8b51090e2f9afe
bca552795994a553e07b38a6f82a233533919926
and the base.pm part of
8901ddee94b1bc3764b4278d1cb26bed30bc2605
This commit removes all the recent stuff that made base.pm localise
@INC and remove a trailing '.'.
This is because perl 5.26.0 will be released with '.' in @INC disabled by
default.
See RT #128769.
commit 2250cd05d3965ba397f971e2e22e2f1e16e0b1de
Author: David Mitchell <davem@iabyn.com>
AuthorDate: Fri Mar 24 08:30:26 2017 +0000
Commit: David Mitchell <davem@iabyn.com>
CommitDate: Fri Mar 24 08:34:12 2017 +0000
bump base.pm $VERSION and un-CUSTOMISE
follow-up to the previous commit's reverting of base.pm @INC changes.
commit 939e7f268559d7c80860c4e1a519e0c25d84f793
Author: David Mitchell <davem@iabyn.com>
AuthorDate: Fri Mar 24 08:48:32 2017 +0000
Commit: David Mitchell <davem@iabyn.com>
CommitDate: Fri Mar 24 08:48:32 2017 +0000
INSTALL: add entry for -Ddefault_inc_excludes_dot
--
My Dad used to say 'always fight fire with fire', which is probably why
he got thrown out of the fire brigade.
Thread Previous
|
Thread Next