On 03/21/2017 12:51 PM, Graham Knop wrote: > On Mon, Mar 20, 2017 at 4:37 PM, James E Keenan via RT > <perlbug-followup@perl.org> wrote: >> On Mon, 20 Mar 2017 12:53:42 GMT, davem wrote: >>> On Mon, Dec 26, 2016 at 06:07:55PM +0100, Sawyer X wrote: >>>> These were all merged but I think we should remove them in favor of >>>> the >>>> upcoming revised patch (based on Chris' comments) by Aristotle, work >>>> in >>>> progress is on ap/baseincguard. >>> Are we still planning to do this for 5.26.0? If not, can this ticket >>> be removed from the blockers list? >> My vote would be to remove it from the blockers list. Even if the work in the ap/baseincguard were to be completed, there's not sufficient time to test it against CPAN before full code freeze. >> >> But this is a pumpking's call. >> >> Thank you very much. > Can't we just revert the base.pm changes without putting anything > extra in place? We're already removing . from @INC globally. There's > little need for base.pm to have its own protections, especially given > how broken the current implementation is. This makes sense. I spoke to Graham more about this on #p5p. There's no need to have an altered base.pm with 5.26.0 (because safe @INC is turned on by default anyway). When base.pm is released separately, it will simply be a different (and up-to-date) version. So we should undo the changes to base.pm in blead. Post 5.26 we could sync it with CPAN.Thread Previous | Thread Next