develooper Front page | perl.perl5.porters | Postings from February 2017

Coro on 5.24.1 (was: Re: [PATCH] - fix for Coro (was Re: revert MGconsting (Coro breakage) for 5.24?))

From:
Sam Kington
Date:
February 6, 2017 13:56
Subject:
Coro on 5.24.1 (was: Re: [PATCH] - fix for Coro (was Re: revert MGconsting (Coro breakage) for 5.24?))
Message ID:
F8DE8D39-C356-4F6D-931A-F5BA2E2562B2@illuminated.co.uk
Hi,

Apologies for thread necromancy, but this seemed like the message to reply to to preserve some context.

On 21 Jul 2016, at 21:08, Steve Hay via perl5-porters <perl5-porters@perl.org> wrote:
> On 18 July 2016 at 17:00, Dave Mitchell <davem@iabyn.com> wrote:
>> On Mon, Jul 18, 2016 at 05:01:21PM +0300, Sergey Aleynikov wrote:
>>> Commit 73949fca082fe50bf47755c5ffa328259057ae36 has never actually
>>> made it into the 5.22 branch.
>>> Is it possible to cherry-pick it for the next maint release (while
>>> they are), as it's currently the only
>>> thing that prevents Coro from compiling on 5.22?
>> 
>> Sign, Marc seems not to have included FC's 4-line patch that would
>> have made Coro build on 5.22.0.
>> 
>> But in any case, I agree that cherry-picking this commit would be good.
>> 
> 
> As discussed in the last onionsketch [1], we have agreement for
> including this in the forthcoming 5.22.3. I wasn't able to verify that
> it fixes the Coro (6.511) build for me [2], but I'll trust the words
> of the others who have spoken here that it does indeed fix the build
> on other OSes, so I've now gone ahead and cherry-picked it. My
> apologies that this got missed from previous 5.22.x releases.
> 
> [1] http://irclog.perlgeek.de/onionsketch/2016-07-18
[…]

It looks like Coro works on 5.22.3 for nearly everyone: http://matrix.cpantesters.org/?dist=Coro+6.511

It still fails on 5.24.1 which was released at the same time, and on all of the 5.25 versions.

Is there anything to be done about this, or is this Marc Lehmann messing with things he shouldn’t (again / more so)?

Sam
-- 
Website: http://www.illuminated.co.uk/



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About