develooper Front page | perl.perl5.porters | Postings from February 2017

Re: [perl #130666] toke.c:9188: S_parse_ident: Assertion `(((constU8*) (PL_parser->bufend)) > ((const U8*) t) || (((const U8*)(PL_parser->bufend)) == ((const U8*) t) && *((const U8*) t) == '\0'))' failed

Thread Previous | Thread Next
From:
Dave Mitchell
Date:
February 1, 2017 16:25
Subject:
Re: [perl #130666] toke.c:9188: S_parse_ident: Assertion `(((constU8*) (PL_parser->bufend)) > ((const U8*) t) || (((const U8*)(PL_parser->bufend)) == ((const U8*) t) && *((const U8*) t) == '\0'))' failed
Message ID:
20170201162517.GA28314@iabyn.com
On Sun, Jan 29, 2017 at 03:14:25PM -0800, Karl Williamson via RT wrote:
> Thanks for finding this; fixed by
> deb0ebcf5f07709222a2073bee27df845a1f14a1

I can't see that commit, but I do see this one:

    commit d2067945159644d284f8064efbd41024f9e8448a
    Author:     Karl Williamson <khw@cpan.org>
    AuthorDate: Sun Jan 29 15:56:20 2017 -0700
    Commit:     Karl Williamson <khw@cpan.org>
    CommitDate: Sun Jan 29 21:05:54 2017 -0700

    PATCH: [perl #130666]: Revert "toke.c, S_scan_ident(): Don't take a "end of buffer" argument, use PL_bufend"
    
    This reverts commit b5248d1e210c2a723adae8e9b7f5d17076647431.

This appears to be cause of the following compiler warning:

    toke.c:9273:41: warning: unused parameter 'send' [-Wunused-parameter]
    S_scan_ident(pTHX_ char *s, const char *send, char *dest, STRLEN destlen, I32 ck_uni)

because that commit seems have added back a 'send' parameter to
S_scan_ident(), but that function still uses PL_bufend for its actual
end-of-string delimiting.

So I'm not sure what the intent was, or how it should be fixed.

-- 
A problem shared is a problem doubled.

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About