develooper Front page | perl.perl5.porters | Postings from January 2017

Re: [perl.git] branch blead, updated. v5.25.9-63-g62a74c3704

Thread Previous
From:
hv
Date:
January 29, 2017 23:56
Subject:
Re: [perl.git] branch blead, updated. v5.25.9-63-g62a74c3704
Message ID:
201701292350.v0TNoZP07770@crypt.org
I wrote:
::So maybe add a flags field or something that allows us to to tell
::reginsert "set up the NEXT_OFF please", which would then clean this
::code up and allow us to not have to mention the PASS2 stuff?
:
:Almost certainly. Let me take a look tonight, it shouldn't take long
:to audit the existing callers.

Hmm, I see rather more than I understand, maybe you should look. :)

The only other case I see setting NEXT_OFF (regcomp.c:11769) also appears
to be calling reginsert() only if PASS2, which seems like it should screw
up the sizing.

There's another "if (!SIZE_ONLY && RExC_extralen) ..." at 11342, but that
has a reginsert() in both branches (BRANCHJ v. BRANCH); that's probably
another example of something that works ok but lies as a trap for
someone to trip over in the future.

Hugo

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About