Front page | perl.perl5.porters |
Postings from January 2017
On Fri, 27 Jan 2017 01:26:03 -0800, demerphq wrote: > Instead of converting the impossible construct into an OPFAIL, we can > inject an OPFAIL in *front* of the impossible construct. Cool, I like. > This patch would have been easier if S_reginsert() documented that it is > the callers responsibility to properly set up the NEXT_OFF() of the inserted > node (if the node has a NEXT_OFF()) Should it be setting that only if PASS2? I didn't think we were supposed to write into the node during sizing. (and earlier) hv> So for now I'm going to look instead whether I can make it less dangerous to hv> miss RExC_recurse entries, that feels like the surer (and more useful) target. dq> That wont work either. Just to clarify: I assume you mean "that won't be enough to let us remove the ops". I'm not entirely sure that I have a use case, but what I had in mind was to modify the fixup loop as in your "this GOSUB may have been optimized away" change, but combine it with a regexec-time check & panic should we see a GOSUB that hasn't had its target set (which requires inventing a way to flag that). Failing that, we should at least have an assert at the point of fixup, for a clea[nr]er failure mode. Hugo --- via perlbug: queue: perl5 status: open https://rt.perl.org/Ticket/Display.html?id=130561Thread Previous | Thread Next