develooper Front page | perl.perl5.porters | Postings from January 2017

Re: [perl #130635] [PATCH] Stack overflow in Storable retrieve_hook

Thread Previous | Thread Next
From:
John Lightsey
Date:
January 25, 2017 19:43
Subject:
Re: [perl #130635] [PATCH] Stack overflow in Storable retrieve_hook
Message ID:
1485373350.3334.4.camel@nixnuts.net
On Wed, 2017-01-25 at 08:12 -0800, James E Keenan via RT wrote:
> 
> On FreeBSD-11, I get the same difference in results between with/without
> -DDEBUGGING.
> 
> On Linux, with -DDEBUGGING, the test file eventually completes ... but clearly
> hangs for some time after 'ok 21' and takes 30s to run.
> 
> So the patch does not play well with -DDEBUGGING regardless of OS.
> 
> Thank you very much.

I'm attaching an updated patch that croaks before these oversized New() calls
rather than trying to handle the failures they generate.


Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About