develooper Front page | perl.perl5.porters | Postings from December 2016

Re: [perl #130122] [PATCH] Cleanup two argument open usage.

Thread Next
John Lightsey
December 23, 2016 23:14
Re: [perl #130122] [PATCH] Cleanup two argument open usage.
Message ID:
On Fri, 2016-12-23 at 11:06 -0800, James E Keenan via RT wrote:

> Pushed to blead in commit 1ae6ead94905dfee43773cf3b18949c91b33f9d1.
> John, can you double-check that commit against your original patch?

The minor code differences look fine to me. Thanks for following through on

> Also, you might want to submit -- in a new perlbug ticket -- a patch to clean
> up 2-arg open() calls like the following which still remain.
> #####
> $> cat dist/Storable/t/code.t
> 193     open(SAVEERR, ">&STDERR");
> 194     open(STDERR, '>', $devnull) or

I left the filehandle-copying opens in the two-argument format for compatibility
with Perl 5.6.2.

If you don't think compatibility with 5.6.2 is worth keeping, particularly in
the /dist/ code, I can make another pass and remove them.
Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About