develooper Front page | perl.perl5.porters | Postings from November 2016

[perl #130169] Fix const correctness for header files

Thread Previous
From:
Tony Cook via RT
Date:
November 30, 2016 23:52
Subject:
[perl #130169] Fix const correctness for header files
Message ID:
rt-4.0.24-16723-1480549919-619.130169-15-0@perl.org
On Mon, 28 Nov 2016 04:22:12 -0800, ppisar wrote:
> On Fri, Nov 25, 2016 at 10:14:41AM -0500, Andy Lester wrote:
> > > Should I bother with compiler pragmata to silent the warning?
> [...]
> > I would be in favor of doing that if it was wrapped in a macro. It
> > would be
> > good to have it explicitly obvious that we are casting away const, so
> > that
> >  we can have the compiler flag the ones we don't mean to cast away.
> 
> Me either. I searched the sources again and I found there had already
> been
> GCC_DIAG_IGNORE and GCC_DIAG_RESTORE macros for that.
> 
> The attached patch that replaces the third patch from the original
> patch set
> uses them to silence the warnings in utf8_hop functions.

Thanks, applied the first two of the original patches and this new patch as 463ddf34c08f2c97199b1bb242da1f17494d4d1a, 9f2eed981068e7abbcc52267863529bc59e9c8c0 and de97954862ed37d913c4b9a48758aba578a8cf0c.

Tony

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=130169

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About