On Mon, 28 Nov 2016 04:22:12 -0800, ppisar wrote: > On Fri, Nov 25, 2016 at 10:14:41AM -0500, Andy Lester wrote: > > > Should I bother with compiler pragmata to silent the warning? > [...] > > I would be in favor of doing that if it was wrapped in a macro. It > > would be > > good to have it explicitly obvious that we are casting away const, so > > that > > we can have the compiler flag the ones we don't mean to cast away. > > Me either. I searched the sources again and I found there had already > been > GCC_DIAG_IGNORE and GCC_DIAG_RESTORE macros for that. > > The attached patch that replaces the third patch from the original > patch set > uses them to silence the warnings in utf8_hop functions. Thanks, applied the first two of the original patches and this new patch as 463ddf34c08f2c97199b1bb242da1f17494d4d1a, 9f2eed981068e7abbcc52267863529bc59e9c8c0 and de97954862ed37d913c4b9a48758aba578a8cf0c. Tony --- via perlbug: queue: perl5 status: open https://rt.perl.org/Ticket/Display.html?id=130169Thread Previous